<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106846/">http://git.reviewboard.kde.org/r/106846/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 6th, 2012, 2:39 p.m., <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Things I found while running a few quick tests:
- Startup with no tags available (my current file), select Tags view, right pane is enabled (should be disabled).
- Create a tag, delete it again. Now right pane is disabled
- Create a new tag, the color button shows gray but when clicking, the color selector shows black (should be consistent)
- while clicking through the application, I got the following error (whatever it means) on the console with a lockup:
*** glibc detected *** kmymoney/kmymoney: invalid fastbin entry (free): 0x0000000002c9d0c0 ***
was unable to reproduce it
Other than that looks really good. We can certainly iron out some more of the details once the code is in the repository.
</pre>
</blockquote>
<p>On November 6th, 2012, 2:44 p.m., <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ooops, testcase failed :(
thb@thb-nb:~/devel/kmymoney/build> make test
Running tests...
Test project /home/thb/devel/kmymoney/build
Start 1: kmymoney-utilstest
1/29 Test #1: kmymoney-utilstest ........................ Passed 0.04 sec
Start 2: kmymoney-mymoneyaccounttest
2/29 Test #2: kmymoney-mymoneyaccounttest ............... Passed 0.02 sec
Start 3: kmymoney-mymoneyexceptiontest
3/29 Test #3: kmymoney-mymoneyexceptiontest ............. Passed 0.01 sec
Start 4: kmymoney-mymoneyfiletest
4/29 Test #4: kmymoney-mymoneyfiletest .................. Passed 0.02 sec
Start 5: kmymoney-mymoneyfinancialcalculatortest
5/29 Test #5: kmymoney-mymoneyfinancialcalculatortest ... Passed 0.02 sec
Start 6: kmymoney-mymoneyforecasttest
6/29 Test #6: kmymoney-mymoneyforecasttest .............. Passed 0.04 sec
Start 7: kmymoney-mymoneyinstitutiontest
7/29 Test #7: kmymoney-mymoneyinstitutiontest ........... Passed 0.02 sec
Start 8: kmymoney-mymoneykeyvaluecontainertest
8/29 Test #8: kmymoney-mymoneykeyvaluecontainertest ..... Passed 0.01 sec
Start 9: kmymoney-mymoneymoneytest
9/29 Test #9: kmymoney-mymoneymoneytest ................. Passed 0.54 sec
Start 10: kmymoney-mymoneyobjecttest
10/29 Test #10: kmymoney-mymoneyobjecttest ................ Passed 0.01 sec
Start 11: kmymoney-mymoneypayeetest
11/29 Test #11: kmymoney-mymoneypayeetest ................. Passed 0.01 sec
Start 12: kmymoney-mymoneytagtest
12/29 Test #12: kmymoney-mymoneytagtest ................... Passed 0.01 sec
Start 13: kmymoney-mymoneypricetest
13/29 Test #13: kmymoney-mymoneypricetest ................. Passed 0.01 sec
Start 14: kmymoney-mymoneyscheduletest
14/29 Test #14: kmymoney-mymoneyscheduletest .............. Passed 0.02 sec
Start 15: kmymoney-mymoneysecuritytest
15/29 Test #15: kmymoney-mymoneysecuritytest .............. Passed 0.01 sec
Start 16: kmymoney-mymoneysplittest
16/29 Test #16: kmymoney-mymoneysplittest ................. Passed 0.01 sec
Start 17: kmymoney-mymoneytransactiontest
17/29 Test #17: kmymoney-mymoneytransactiontest ...........***Failed 0.01 sec
Start 18: kmymoney-mymoneybudgettest
18/29 Test #18: kmymoney-mymoneybudgettest ................ Passed 0.01 sec
Start 19: kmymoney-mymoneybalancecachetest
19/29 Test #19: kmymoney-mymoneybalancecachetest .......... Passed 0.01 sec
Start 20: kmymoney-mymoneydatabasemgrtest
20/29 Test #20: kmymoney-mymoneydatabasemgrtest ........... Passed 125.74 sec
Start 21: kmymoney-mymoneymaptest
21/29 Test #21: kmymoney-mymoneymaptest ................... Passed 0.02 sec
Start 22: kmymoney-mymoneyseqaccessmgrtest
22/29 Test #22: kmymoney-mymoneyseqaccessmgrtest .......... Passed 0.02 sec
Start 23: kmymoney-plugin-csvdatetest
23/29 Test #23: kmymoney-plugin-csvdatetest ............... Passed 0.01 sec
Start 24: kmymoney-plugin-parsedatatest
24/29 Test #24: kmymoney-plugin-parsedatatest ............. Passed 0.02 sec
Start 25: kmymoney-plugin-symboltest
25/29 Test #25: kmymoney-plugin-symboltest ................ Passed 0.02 sec
Start 26: kmymoney-pivotgridtest
26/29 Test #26: kmymoney-pivotgridtest .................... Passed 0.01 sec
Start 27: kmymoney-pivottabletest
27/29 Test #27: kmymoney-pivottabletest ................... Passed 0.11 sec
Start 28: kmymoney-querytabletest
28/29 Test #28: kmymoney-querytabletest ................... Passed 0.07 sec
Start 29: kmymoney-convertertest
29/29 Test #29: kmymoney-convertertest .................... Passed 0.02 sec
97% tests passed, 1 tests failed out of 29
Total Test time (real) = 126.95 sec
The following tests FAILED:
17 - kmymoney-mymoneytransactiontest (Failed)
Errors while running CTest
make: *** [test] Error 8
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-first and second: the same happens for the Payee tab, I fixed it there too.
-third: new tags are created with an invalid color, I'll assign them the black color
-crash: no idea!
About the test case: If fixed it, the bug was in the test mymoneytransactiontest.cpp
I found another bug (in tagview and payeeview): if you modify a tag/payee and than click on an empty space in the tag/payee list no dialog appear asking you if you want to save the changes. I think I fixed it be I would be glad if you can take a look.</pre>
<br />
<p>- Alessandro</p>
<br />
<p>On November 1st, 2012, 11:07 p.m., Alessandro Russo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Alessandro Russo.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2012, 11:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) I created and almost completed the Tag tab in KMyMoneyView (KTagsView),
it's similar to the payees tab.
2) I modified many classes in the storage folder and created a new class
MyMoneyTag similar to MyMoneyPayee, now Tags save and load correctly but not
all tag attribute (visibibleFrom,etc..) are saved/loaded yet.
3) I changed transactioneditor, transaction and KGlobalLedgerView, now there
is a new widget called Tags in the translationeditor that someway works but
no tags are shown in the ledger yet and no widget is showed when you insert
or edit a transaction directly from the ledger (is this a feature that
somebody uses?).
4) Missing features:
- multi tags per transaction (only 1 tag can be added at this time)
- no tag selection in reports
- hierarchical tags (I'm rethinking about the real usefulness of this
one... as implementing it will require some work )
- in the tag tab you can select a color for the tag, this will be used to
show the tag in the ledger with this color, also no visibility check is
made.
- no tags in a split
Bugs:
- in the tag tab if you select a tag and click on the 'New tag' button the
selected tag wil be deleted and replaced with an empy "NewTag"
- in the transaction editor when you edit a transaction with a tag the tag
field is empty, when not in edit mode it show the tag name correctly.
- many more... </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wrote and run test cases. Several tests in xml and sql storage mode.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=207761">207761</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/CMakeLists.txt <span style="color: grey">(9a8d782)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlg.h <span style="color: grey">(397d623)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlg.cpp <span style="color: grey">(506d752)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlgdecl.ui <span style="color: grey">(d9e95ce)</span></li>
<li>kmymoney/dialogs/kreportconfigurationfilterdlg.cpp <span style="color: grey">(a50de29)</span></li>
<li>kmymoney/dialogs/ktagreassigndlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/dialogs/ktagreassigndlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/dialogs/ktagreassigndlgdecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/dialogs/transactioneditor.h <span style="color: grey">(2535d96)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(06c7fd1)</span></li>
<li>kmymoney/kmymoney.h <span style="color: grey">(9482812)</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(1ef7400)</span></li>
<li>kmymoney/kmymoney.kcfg <span style="color: grey">(95e33df)</span></li>
<li>kmymoney/kmymoneyui.rc <span style="color: grey">(4294c46)</span></li>
<li>kmymoney/mymoney/CMakeLists.txt <span style="color: grey">(d2917b5)</span></li>
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(6c1aa25)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(eef7126)</span></li>
<li>kmymoney/mymoney/mymoneyobjectcontainer.h <span style="color: grey">(21cd74c)</span></li>
<li>kmymoney/mymoney/mymoneyobjectcontainer.cpp <span style="color: grey">(2e9c496)</span></li>
<li>kmymoney/mymoney/mymoneyreport.h <span style="color: grey">(7747353)</span></li>
<li>kmymoney/mymoney/mymoneyreport.cpp <span style="color: grey">(24d75d8)</span></li>
<li>kmymoney/mymoney/mymoneysplit.h <span style="color: grey">(ded6b4c)</span></li>
<li>kmymoney/mymoney/mymoneysplit.cpp <span style="color: grey">(168d1e6)</span></li>
<li>kmymoney/mymoney/mymoneysplittest.cpp <span style="color: grey">(f0d8851)</span></li>
<li>kmymoney/mymoney/mymoneytag.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/mymoney/mymoneytag.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/mymoney/mymoneytagtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/mymoney/mymoneytagtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/mymoney/mymoneytransactionfilter.h <span style="color: grey">(2a7b85d)</span></li>
<li>kmymoney/mymoney/mymoneytransactionfilter.cpp <span style="color: grey">(6650fef)</span></li>
<li>kmymoney/mymoney/mymoneytransactiontest.cpp <span style="color: grey">(f1a9687)</span></li>
<li>kmymoney/mymoney/storage/CMakeLists.txt <span style="color: grey">(0495726)</span></li>
<li>kmymoney/mymoney/storage/imymoneyserialize.h <span style="color: grey">(ff49986)</span></li>
<li>kmymoney/mymoney/storage/imymoneystorage.h <span style="color: grey">(8b980b7)</span></li>
<li>kmymoney/mymoney/storage/mymoneydatabasemgr.h <span style="color: grey">(ab587ed)</span></li>
<li>kmymoney/mymoney/storage/mymoneydatabasemgr.cpp <span style="color: grey">(f98a965)</span></li>
<li>kmymoney/mymoney/storage/mymoneydatabasemgrtest.h <span style="color: grey">(f2d05f2)</span></li>
<li>kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp <span style="color: grey">(d31bb02)</span></li>
<li>kmymoney/mymoney/storage/mymoneydbdef.h <span style="color: grey">(a2eecaf)</span></li>
<li>kmymoney/mymoney/storage/mymoneydbdef.cpp <span style="color: grey">(9fa9781)</span></li>
<li>kmymoney/mymoney/storage/mymoneyseqaccessmgr.h <span style="color: grey">(da67e58)</span></li>
<li>kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp <span style="color: grey">(232d6b2)</span></li>
<li>kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.h <span style="color: grey">(c13d3da)</span></li>
<li>kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.cpp <span style="color: grey">(66354e4)</span></li>
<li>kmymoney/mymoney/storage/mymoneystorageanon.h <span style="color: grey">(482fc9d)</span></li>
<li>kmymoney/mymoney/storage/mymoneystorageanon.cpp <span style="color: grey">(0e7ebdd)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragebin.h <span style="color: grey">(af2b254)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragedump.cpp <span style="color: grey">(d36b4bb)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragesql.h <span style="color: grey">(73875b3)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragesql.cpp <span style="color: grey">(90ee818)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragexml.h <span style="color: grey">(126cf8c)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragexml.cpp <span style="color: grey">(88a02df)</span></li>
<li>kmymoney/reports/listtable.cpp <span style="color: grey">(d163f58)</span></li>
<li>kmymoney/reports/querytable.cpp <span style="color: grey">(697f425)</span></li>
<li>kmymoney/views/CMakeLists.txt <span style="color: grey">(de0272f)</span></li>
<li>kmymoney/views/kgloballedgerview.cpp <span style="color: grey">(dfaecbd)</span></li>
<li>kmymoney/views/kmymoneyview.h <span style="color: grey">(99ab398)</span></li>
<li>kmymoney/views/kmymoneyview.cpp <span style="color: grey">(49dcc85)</span></li>
<li>kmymoney/views/kreportsview.cpp <span style="color: grey">(a868689)</span></li>
<li>kmymoney/views/ktagsview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/views/ktagsview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/views/ktagsviewdecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/widgets/kmymoney.widgets <span style="color: grey">(857e42c)</span></li>
<li>kmymoney/widgets/kmymoneymvccombo.h <span style="color: grey">(305e8a1)</span></li>
<li>kmymoney/widgets/kmymoneymvccombo.cpp <span style="color: grey">(42a3687)</span></li>
<li>kmymoney/widgets/kmymoneyreportconfigtab3decl.ui <span style="color: grey">(ab150ee)</span></li>
<li>kmymoney/widgets/transaction.h <span style="color: grey">(a28053e)</span></li>
<li>kmymoney/widgets/transaction.cpp <span style="color: grey">(bfaafbf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106846/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>