<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106846/">http://git.reviewboard.kde.org/r/106846/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Alessandro Russo.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2012, 9:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fixed icons names.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) I created and almost completed the Tag tab in KMyMoneyView (KTagsView),
it's similar to the payees tab.
2) I modified many classes in the storage folder and created a new class
MyMoneyTag similar to MyMoneyPayee, now Tags save and load correctly but not
all tag attribute (visibibleFrom,etc..) are saved/loaded yet.
3) I changed transactioneditor, transaction and KGlobalLedgerView, now there
is a new widget called Tags in the translationeditor that someway works but
no tags are shown in the ledger yet and no widget is showed when you insert
or edit a transaction directly from the ledger (is this a feature that
somebody uses?).
4) Missing features:
- multi tags per transaction (only 1 tag can be added at this time)
- no tag selection in reports
- hierarchical tags (I'm rethinking about the real usefulness of this
one... as implementing it will require some work )
- in the tag tab you can select a color for the tag, this will be used to
show the tag in the ledger with this color, also no visibility check is
made.
- no tags in a split
Bugs:
- in the tag tab if you select a tag and click on the 'New tag' button the
selected tag wil be deleted and replaced with an empy "NewTag"
- in the transaction editor when you edit a transaction with a tag the tag
field is empty, when not in edit mode it show the tag name correctly.
- many more... </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wrote and run test cases. Several tests in xml and sql storage mode.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=207761">207761</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/mymoney/CMakeLists.txt <span style="color: grey">(d2917b5)</span></li>
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(6c1aa25)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(eef7126)</span></li>
<li>kmymoney/kmymoney.kcfg <span style="color: grey">(95e33df)</span></li>
<li>kmymoney/kmymoneyui.rc <span style="color: grey">(4294c46)</span></li>
<li>kmymoney/dialogs/ktagreassigndlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/dialogs/ktagreassigndlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/dialogs/ktagreassigndlgdecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/dialogs/transactioneditor.h <span style="color: grey">(2535d96)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(06c7fd1)</span></li>
<li>kmymoney/kmymoney.h <span style="color: grey">(9482812)</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(1ef7400)</span></li>
<li>kmymoney/dialogs/CMakeLists.txt <span style="color: grey">(9a8d782)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlg.h <span style="color: grey">(397d623)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlg.cpp <span style="color: grey">(506d752)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlgdecl.ui <span style="color: grey">(d9e95ce)</span></li>
<li>kmymoney/dialogs/kreportconfigurationfilterdlg.cpp <span style="color: grey">(a50de29)</span></li>
<li>kmymoney/mymoney/mymoneyobjectcontainer.h <span style="color: grey">(21cd74c)</span></li>
<li>kmymoney/mymoney/mymoneyobjectcontainer.cpp <span style="color: grey">(2e9c496)</span></li>
<li>kmymoney/mymoney/mymoneyreport.h <span style="color: grey">(7747353)</span></li>
<li>kmymoney/mymoney/mymoneyreport.cpp <span style="color: grey">(24d75d8)</span></li>
<li>kmymoney/mymoney/mymoneysplit.h <span style="color: grey">(ded6b4c)</span></li>
<li>kmymoney/mymoney/mymoneysplit.cpp <span style="color: grey">(168d1e6)</span></li>
<li>kmymoney/mymoney/mymoneysplittest.cpp <span style="color: grey">(f0d8851)</span></li>
<li>kmymoney/mymoney/mymoneytag.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/mymoney/mymoneytag.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/mymoney/mymoneytagtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/mymoney/mymoneytagtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/mymoney/mymoneytransactionfilter.h <span style="color: grey">(2a7b85d)</span></li>
<li>kmymoney/mymoney/mymoneytransactionfilter.cpp <span style="color: grey">(6650fef)</span></li>
<li>kmymoney/mymoney/mymoneytransactiontest.cpp <span style="color: grey">(f1a9687)</span></li>
<li>kmymoney/mymoney/storage/CMakeLists.txt <span style="color: grey">(0495726)</span></li>
<li>kmymoney/mymoney/storage/imymoneyserialize.h <span style="color: grey">(ff49986)</span></li>
<li>kmymoney/mymoney/storage/imymoneystorage.h <span style="color: grey">(8b980b7)</span></li>
<li>kmymoney/mymoney/storage/mymoneydatabasemgr.h <span style="color: grey">(ab587ed)</span></li>
<li>kmymoney/mymoney/storage/mymoneydatabasemgr.cpp <span style="color: grey">(f98a965)</span></li>
<li>kmymoney/mymoney/storage/mymoneydatabasemgrtest.h <span style="color: grey">(f2d05f2)</span></li>
<li>kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp <span style="color: grey">(d31bb02)</span></li>
<li>kmymoney/mymoney/storage/mymoneydbdef.h <span style="color: grey">(a2eecaf)</span></li>
<li>kmymoney/mymoney/storage/mymoneydbdef.cpp <span style="color: grey">(9fa9781)</span></li>
<li>kmymoney/mymoney/storage/mymoneyseqaccessmgr.h <span style="color: grey">(da67e58)</span></li>
<li>kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp <span style="color: grey">(232d6b2)</span></li>
<li>kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.h <span style="color: grey">(c13d3da)</span></li>
<li>kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.cpp <span style="color: grey">(66354e4)</span></li>
<li>kmymoney/mymoney/storage/mymoneystorageanon.h <span style="color: grey">(482fc9d)</span></li>
<li>kmymoney/mymoney/storage/mymoneystorageanon.cpp <span style="color: grey">(0e7ebdd)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragebin.h <span style="color: grey">(af2b254)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragedump.cpp <span style="color: grey">(d36b4bb)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragesql.h <span style="color: grey">(73875b3)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragesql.cpp <span style="color: grey">(90ee818)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragexml.h <span style="color: grey">(126cf8c)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragexml.cpp <span style="color: grey">(88a02df)</span></li>
<li>kmymoney/reports/listtable.cpp <span style="color: grey">(d163f58)</span></li>
<li>kmymoney/reports/querytable.cpp <span style="color: grey">(697f425)</span></li>
<li>kmymoney/views/CMakeLists.txt <span style="color: grey">(de0272f)</span></li>
<li>kmymoney/views/kgloballedgerview.cpp <span style="color: grey">(dfaecbd)</span></li>
<li>kmymoney/views/kmymoneyview.h <span style="color: grey">(99ab398)</span></li>
<li>kmymoney/views/kmymoneyview.cpp <span style="color: grey">(49dcc85)</span></li>
<li>kmymoney/views/kreportsview.cpp <span style="color: grey">(a868689)</span></li>
<li>kmymoney/views/ktagsview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/views/ktagsview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/views/ktagsviewdecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/widgets/kmymoney.widgets <span style="color: grey">(857e42c)</span></li>
<li>kmymoney/widgets/kmymoneymvccombo.h <span style="color: grey">(305e8a1)</span></li>
<li>kmymoney/widgets/kmymoneymvccombo.cpp <span style="color: grey">(42a3687)</span></li>
<li>kmymoney/widgets/kmymoneyreportconfigtab3decl.ui <span style="color: grey">(ab150ee)</span></li>
<li>kmymoney/widgets/transaction.h <span style="color: grey">(a28053e)</span></li>
<li>kmymoney/widgets/transaction.cpp <span style="color: grey">(bfaafbf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106846/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>