<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104044/">http://git.reviewboard.kde.org/r/104044/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Cristian Oneț.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using 'long double' MyMoneyFinancialCalculator is pretty awkward since it's values can be either 'long double' or 'double' depending on the fact that the 'long double' type is found or not. But in the client code there is plain usage of the 'long double' type so the whole type detection seems useless.
It's also useless considering that MyMoneyMoney objects have a conversion to 'double' but no conversion to 'long double'.
So I decided that 'long double' should be removed (from the client code also), thus making the code cleaner without loosing anything (on some platforms 'long double' is just a typedef to 'double').
This also fixes the test failing on Windows on both MSVC and mingw4 platforms.
In the places where we need arbitrary precision (inside MyMoneyFinancialCalculator) the double types should be replaced with MyMoneyMoney objects anyway.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran tests on Linux/Windows(MSVC and mingw4) and they all passed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9ea55de)</span></li>
<li>config-kmymoney.h.cmake <span style="color: grey">(75a79c0)</span></li>
<li>kmymoney/mymoney/mymoneyfinancialcalculator.h <span style="color: grey">(1fea9f6)</span></li>
<li>kmymoney/mymoney/mymoneyfinancialcalculator.cpp <span style="color: grey">(eee28f8)</span></li>
<li>kmymoney/mymoney/mymoneyforecast.cpp <span style="color: grey">(fe0cfdc)</span></li>
<li>kmymoney/mymoney/mymoneymoney.h <span style="color: grey">(3902c88)</span></li>
<li>kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp <span style="color: grey">(a35cb16)</span></li>
<li>kmymoney/wizards/newaccountwizard/knewaccountwizard_p.h <span style="color: grey">(0575771)</span></li>
<li>kmymoney/wizards/newloanwizard/durationwizardpage.h <span style="color: grey">(6781b88)</span></li>
<li>kmymoney/wizards/newloanwizard/durationwizardpage.cpp <span style="color: grey">(c68fac8)</span></li>
<li>kmymoney/wizards/newloanwizard/knewloanwizard.cpp <span style="color: grey">(e473e4a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104044/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>