<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I'm hoping to have another look at the code this week.<br>
<br>
Ian<br>
<br>
Cristian Oneț wrote:
<blockquote cite="mid:20120217211344.5666.89692@vidsolbach.de"
type="cite">
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table style="border: 1px #c9c399 solid;" bgcolor="#f9f3c9"
cellpadding="8" width="100%">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To reply,
visit: <a moz-do-not-send="true"
href="http://git.reviewboard.kde.org/r/103456/">http://git.reviewboard.kde.org/r/103456/</a>
</td>
</tr>
</tbody>
</table>
<br>
<blockquote style="margin-left: 1em; border-left: 2px solid
#d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 2nd, 2012, 11:08 a.m., <b>Thomas
Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid
#d0d0d0; padding-left: 10px;">
<table style="border: 1px solid #C0C0C0; border-collapse:
collapse; margin: 2px padding: 2px;" bgcolor="white"
border="0" width="100%">
<thead> <tr>
<th colspan="4" style="border-bottom: 1px solid
#C0C0C0; font-size: 9pt; padding: 4px 8px;
text-align: left;" bgcolor="#F0F0F0"> <a
moz-do-not-send="true"
href="http://git.reviewboard.kde.org/r/103456/diff/1/?file=43834#file43834line478"
style="color: black; font-weight: bold;
text-decoration: underline;">kmymoney/dialogs/keditscheduledlg.cpp</a>
<span style="font-weight: normal;"> (Diff revision
1) </span> </th>
</tr>
</thead> <tbody style="background-color: #e4d9cb;
padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4">
<pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KEditScheduleDlg::slotRemainingChanged(int value)</pre>
</td>
</tr>
</tbody> <tbody>
<tr>
<th style="border-right: 1px solid #C0C0C0;"
align="right" bgcolor="#e9eaa8"><font size="2">464</font></th>
<td bgcolor="#fdfebc" width="50%">
<pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_FinalPaymentEdit</span><span class="o">-></span><span class="n">setDate</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">m_schedule</span><span class="p">.</span><span class="n">dateAfter</span><span class="p">(</span><span class="n">value</span><span class="p">));</span></pre>
</td>
<th style="border-left: 1px solid #C0C0C0;
border-right: 1px solid #C0C0C0;" align="right"
bgcolor="#e9eaa8"><font size="2">466</font></th>
<td bgcolor="#fdfebc" width="50%">
<pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_FinalPaymentEdit</span><span class="o">-></span><span class="n">setDate</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">m_schedule</span><span class="p">.</span><span class="n">adjustedDate</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">m_schedule</span><span class="p">.</span><span class="n">dateAfter</span><span class="p">(</span><span class="n">value</span><span class="p">),</span> <span class="n">convertWeekendOption</span><span class="p">(</span><span class="n">m_weekendOptionEdit</span><span class="o">-></span><span class="n">currentIndex</span><span class="p">())));</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I expect this to break the logic! Try what happens with the following data: start 30.12.2011, end 1.1.2011, change date to previous processing day. It should have 3 payments. Then save the entry and edit it again. Does it still have 3 payments? BTW: I expect the latest patch attached to <a class="moz-txt-link-freetext" href="https://bugs.kde.org/show_bug.cgi?id=290059">https://bugs.kde.org/show_bug.cgi?id=290059</a> be installed.</pre>
</blockquote>
<p>On January 2nd, 2012, 11:17 a.m., <b>Thomas Baumgart</b>
wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid
#d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Of course I mean 1.1.2012 to be the end date.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What is the status of this review request?</pre>
<br>
<p>- Cristian</p>
<br>
<p>On December 18th, 2011, 9:20 p.m., Ian Neal wrote:</p>
<table style="background-image:
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png');
background-position: left top; background-repeat: repeat-x;
border: 1px black solid;" bgcolor="#fefadf" cellpadding="8"
cellspacing="0" width="100%">
<tbody>
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Ian Neal.</div>
<p style="color: grey;"><i>Updated Dec. 18, 2011, 9:20
p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Description </h1>
<table style="border: 1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changing remaining transactions on scheduled transaction with a weekend option set can show an incorrect scheduled date</pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Testing </h1>
<table style="border: 1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with patch, edit scheduled transaction dialog only shows processing dates when changing number of remaining transactions, best tested with a daily repeating transaction with 30 transactions.</pre>
</td>
</tr>
</tbody>
</table>
<div style="margin-top: 1.5em;"> <b style="color:
#575012; font-size: 10pt; margin-top: 1.5em;">Bugs:
</b> <a moz-do-not-send="true"
href="http://bugs.kde.org/show_bug.cgi?id=289306">289306</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/keditscheduledlg.h <span
style="color: grey">(83fc913bc0a9590f6194520f27641fbad160be67)</span></li>
<li>kmymoney/dialogs/keditscheduledlg.cpp <span
style="color: grey">(7ddf3c3edd763992960cb86e52c5bb6d68efb9e6)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="http://git.reviewboard.kde.org/r/103456/diff/"
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
</blockquote>
<br>
</body>
</html>