<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103264/">http://git.reviewboard.kde.org/r/103264/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 2nd, 2011, 10:47 p.m., <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103264/diff/6-7/?file=42461#file42461line2071" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/mymoney/mymoneyfiletest.cpp</a>
<span style="font-weight: normal;">
(Diff revisions 6 - 7)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MyMoneyFileTest::testStorageId()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">2071</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">// QVERIFY(m->hasMatchingOnlineBalance(a) == false);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2065</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ft</span><span class="p">.</span><span class="n">restart</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good to know that "ft.restart()" rewinds the transaction made.
Actually, does it rewind ALL transactions made since creating "ft", or only the previously committed transaction?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It does not rewind any transactions at all. The MyMoneyFileTransaction object can only encapsulate a single transaction. It starts by creating the object and terminates when you call commit() or rollback(). Destroying it call rollback() automagically. In order to reuse it for a second transaction as in this case, you can use restart() to prepare the object for another transaction.
I just see that the documentation of this class is rather slim.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On December 2nd, 2011, 10:43 p.m., Marko Käning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2011, 10:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Highlighting of online statement balance with red background and
highlighted text if file balance and online balance are different.
(This patch was put together from Thomas' and Cristian's advice on ML)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=287494">287494</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(d44e2ea)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(f573f9a)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.h <span style="color: grey">(ad5c687)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.cpp <span style="color: grey">(a3c17ed)</span></li>
<li>kmymoney/widgets/register.h <span style="color: grey">(8cd1a32)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(e62fe63)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103264/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103264/s/345/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/27/KMM-online-balance-highlight_400x100.tiff" style="border: 1px black solid;" alt="small snapshot showing the highlighted group marker" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>