<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103142/">http://git.reviewboard.kde.org/r/103142/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 16th, 2011, 9:51 p.m., <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Runtime issues:
1. If you go back from step 2 you can't select a file until you reselect the import type, although a valid type is already selected
2. If I try to import the test.csv file I'm sending by mail to you I'm getting an import failed error with the reason being an invalid date (I've selected 'd m y')
3. If you go back from step 6 and the go forward again without changing anything the 'Import CSV' action is missing although a valid decimal separator is already selected
</pre>
</blockquote>
<p>On November 16th, 2011, 10:39 p.m., <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. If you go back from step 2 you can't select a file until you reselect the import type, although a valid type is already selected.
That is deliberate, as, selecting the account type loads the appropriate part of the resource file, which, in turn, enables the 'Next' button. Perhaps I should clear the combobox, although I have been intending later to use a hint in the combobox.
2. If I try to import the test.csv file I'm sending by mail to you I'm getting an import failed error with the reason being an invalid date (I've selected 'd m y').
I'll look into that.
3. If you go back from step 6 and the go forward again without changing anything the 'Import CSV' action is missing although a valid decimal separator is already selected.
Yes, that's by design. When the decimal symbol is selected, it triggers a validation of the selected entry values, and highlights success or problem selections. Again, perhaps I need to clear the current combobox selection.</pre>
</blockquote>
<p>On November 16th, 2011, 10:51 p.m., <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. I can understand this technical description but from a usability POV it's not
valid to say 'a this is how it works, you need to reselect the type (although
it's already selected) just because I've implemented my programming stuff on
the selection action and it is mandatory' - you know what I mean - clearing
the combobox would just trigger a 'damn! where did my selection go!?'
3. The same as point 1, you could trigger that stuff also when entering the page
with a valid value in the respective fields.
P.S: sorry for the double posting on the mailing list</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. I'll need to look closely, in case there was another reason to do it this way, as it was done quite a while ago.
2. Operator error!
3. As for 1. It was to ensure the user had made a conscious decision on selection. In a normal user environment, I expect that generally only the one decimal symbol will be encountered, so it's probably OK to leave an existing selection. If he makes a mistake, then he'll just have a bit more work to do to back-track and change it.
</pre>
<br />
<p>- Allan</p>
<br />
<p>On November 15th, 2011, 9:09 p.m., Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2011, 9:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This was submitted originally as http://svn.reviewboard.kde.org/r/6818/ on 28 October.
The two earlier versions of the plugin suffered from different difficulties in the UI. A wizard approach has now been adopted, to give better guidance to the user of the flow in the UI.
Also, in the investment section of the earlier versions, only simple CSV files could be catered for, where the file contained just a single security. When files from brokers become involved, this is a different kettle of fish all together. I've added support for two brokers, Merril Lynch and Schwab. Their files may contain several securities, and the investment activity type may not be in a separate column, but buried in a Detail column. In fact, the requirements for just these two brokers were conflicting, and dealing with both correctly became pretty complex. The names used to define the security may vary within a file and may be different from those in use by the user, so the user has the opportunity to edit the security names during the import process.
A further problem was that some files did not use ticker symbols on all investment lines, and this is necessary for compatibility with KMyMoney. It will therefore be necessary for the user to add symbols to the input file beforehand, although as long as they are used consistently, they do not need to be 'real' symbols.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests run, plus astyle and krazy. Numerous files processed, including live work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/CMakeLists.txt <span style="color: grey">(1ca4590)</span></li>
<li>kmymoney/plugins/csvimport/bankingwizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/completionwizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/convdate.cpp <span style="color: grey">(c5e1bab)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterdlg.h <span style="color: grey">(5773724)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterdlg.cpp <span style="color: grey">(757622f)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterdlgdecl.ui <span style="color: grey">(e476d0a)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.h <span style="color: grey">(4f3e818)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.cpp <span style="color: grey">(3ec87a3)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterrc <span style="color: grey">(672be35)</span></li>
<li>kmymoney/plugins/csvimport/csvprocessing.h <span style="color: grey">(21c2720)</span></li>
<li>kmymoney/plugins/csvimport/csvprocessing.cpp <span style="color: grey">(00f2815)</span></li>
<li>kmymoney/plugins/csvimport/csvutil.h <span style="color: grey">(b53cb5a)</span></li>
<li>kmymoney/plugins/csvimport/csvutil.cpp <span style="color: grey">(fc3d136)</span></li>
<li>kmymoney/plugins/csvimport/introwizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/investmentdlg.h <span style="color: grey">(b50800d)</span></li>
<li>kmymoney/plugins/csvimport/investmentdlg.cpp <span style="color: grey">(679370d)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(337b485)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(feb808b)</span></li>
<li>kmymoney/plugins/csvimport/lines-datewizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlg.h <span style="color: grey">(1385feb)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlg.cpp <span style="color: grey">(332985a)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlgdecl.ui <span style="color: grey">(58fc5cd)</span></li>
<li>kmymoney/plugins/csvimport/separatorwizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/symboltabledlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/symboltabledlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/symboltabledlg.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103142/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>