<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103142/">http://git.reviewboard.kde.org/r/103142/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103142/diff/2/?file=41130#file41130line799" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/plugins/csvimport/csvdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CSVDialog::csvImportTransaction(MyMoneyStatement& st)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">799</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">tr</span><span class="p">.</span><span class="n">m_amount</span> <span class="o">=</span> <span class="n">m_trData</span><span class="p">.</span><span class="n">amount</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use tr.m_amount = MyMoneyMoney(m_trData.amount); instead to make sure that the amount string is interpreted with KGlobal::locale()->decimalSymbol() like it's constructed in csvutil.cpp:284</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103142/diff/2/?file=41130#file41130line800" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/plugins/csvimport/csvdialog.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CSVDialog::csvImportTransaction(MyMoneyStatement& st)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">800</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">tr</span><span class="p">.</span><span class="n">m_shares</span> <span class="o">=</span> <span class="n">m_trData</span><span class="p">.</span><span class="n">amount</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use tr.m_shares = MyMoneyMoney(m_trData.amount); instead to make sure that the amount string is interpreted with KGlobal::locale()->decimalSymbol() like it's constructed in csvutil.cpp:284</pre>
</div>
<br />
<p>- Cristian</p>
<br />
<p>On November 15th, 2011, 9:09 p.m., Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2011, 9:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This was submitted originally as http://svn.reviewboard.kde.org/r/6818/ on 28 October.
The two earlier versions of the plugin suffered from different difficulties in the UI. A wizard approach has now been adopted, to give better guidance to the user of the flow in the UI.
Also, in the investment section of the earlier versions, only simple CSV files could be catered for, where the file contained just a single security. When files from brokers become involved, this is a different kettle of fish all together. I've added support for two brokers, Merril Lynch and Schwab. Their files may contain several securities, and the investment activity type may not be in a separate column, but buried in a Detail column. In fact, the requirements for just these two brokers were conflicting, and dealing with both correctly became pretty complex. The names used to define the security may vary within a file and may be different from those in use by the user, so the user has the opportunity to edit the security names during the import process.
A further problem was that some files did not use ticker symbols on all investment lines, and this is necessary for compatibility with KMyMoney. It will therefore be necessary for the user to add symbols to the input file beforehand, although as long as they are used consistently, they do not need to be 'real' symbols.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests run, plus astyle and krazy. Numerous files processed, including live work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/CMakeLists.txt <span style="color: grey">(1ca4590)</span></li>
<li>kmymoney/plugins/csvimport/bankingwizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/completionwizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/convdate.cpp <span style="color: grey">(c5e1bab)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterdlg.h <span style="color: grey">(5773724)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterdlg.cpp <span style="color: grey">(757622f)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterdlgdecl.ui <span style="color: grey">(e476d0a)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.h <span style="color: grey">(4f3e818)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.cpp <span style="color: grey">(3ec87a3)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterrc <span style="color: grey">(672be35)</span></li>
<li>kmymoney/plugins/csvimport/csvprocessing.h <span style="color: grey">(21c2720)</span></li>
<li>kmymoney/plugins/csvimport/csvprocessing.cpp <span style="color: grey">(00f2815)</span></li>
<li>kmymoney/plugins/csvimport/csvutil.h <span style="color: grey">(b53cb5a)</span></li>
<li>kmymoney/plugins/csvimport/csvutil.cpp <span style="color: grey">(fc3d136)</span></li>
<li>kmymoney/plugins/csvimport/introwizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/investmentdlg.h <span style="color: grey">(b50800d)</span></li>
<li>kmymoney/plugins/csvimport/investmentdlg.cpp <span style="color: grey">(679370d)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(337b485)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(feb808b)</span></li>
<li>kmymoney/plugins/csvimport/lines-datewizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlg.h <span style="color: grey">(1385feb)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlg.cpp <span style="color: grey">(332985a)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlgdecl.ui <span style="color: grey">(58fc5cd)</span></li>
<li>kmymoney/plugins/csvimport/separatorwizardpage.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/symboltabledlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/symboltabledlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/symboltabledlg.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103142/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>