<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6777/">http://svn.reviewboard.kde.org/r/6777/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Thomas Baumgart.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2011, 7:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated patch to contain missing new file importoption.ui</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch allows to select the source of the payee information for file imports. It supports the same settings as the OFX direct connect version. The selection is (currently) non-persistent and defaults to the payee id field.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Due to the lack of OFX files that require the setting to be changed, I only added some debug statements (which have been removed in the patch) to verify that the controlling variable d->m_preferName is setup correctly after the dialog is closed. Further processing should be identical to the OFX direct connect version.
Someone who needs this option should do some more testing and report about the results.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=271734">271734</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/extragear/office/kmymoney/kmymoney/kmymoney.h <span style="color: grey">(1249345)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp <span style="color: grey">(1249345)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/importinterface.h <span style="color: grey">(1249345)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/interfaces/kmmimportinterface.h <span style="color: grey">(1249345)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/interfaces/kmmimportinterface.cpp <span style="color: grey">(1249345)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/CMakeLists.txt <span style="color: grey">(1249345)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/importoption.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/ofximporterplugin.cpp <span style="color: grey">(1249345)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6777/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/6777/s/618/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2011/08/23/ofx-payee-source_400x100.png" style="border: 1px black solid;" alt="OFX file open dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>