<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5310/">http://svn.reviewboard.kde.org/r/5310/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 28th, 2011, 1:10 p.m., <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looking only at the csv plugin, I can see only one material change. The remainder seem to be white-space issues, particularly with 'if (...)' or 'for (...)', the original ones coming via astyle. I was concerned as I'm in mid-change!
Allan</pre>
</blockquote>
<p>On February 28th, 2011, 3:56 p.m., <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you're in mid-change we can wait until you're done. Please let us know if you want to use this option.</pre>
</blockquote>
<p>On February 28th, 2011, 4:22 p.m., <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, in fact, I'm nearly done. Some final touches, tidy up and final testing should only take a day or two at the most.
I was assuming I'd be using if only indirectly. Without having yet read up about it, I was taking it that it would modify mymoneymoney, but I see you refer to it as an option.
My use of mymoneymoney is pretty minimal. You suggested I use it in place of double where I have to multiply a price by a fraction, and also when applying a fee as a percentage, which I did. In fact, I still had to use a double to get a string I could format (or so I believed).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi.
I've updated kmymoney in my system using the new patch. I created a package for libalkimia 0.9.2 in my system to link with kmymoney.
I'm using a 1-year history file here with about 10 different accounts and no issues. Tested some charts and they are working. I don't have enough time and knowledge of the code to do more extensive tests.
What I can say is that code is better than without libalkimia and even if the code has some (not found) bugs, its usable.</pre>
<br />
<p>- Jose</p>
<br />
<p>On February 27th, 2011, 10:40 p.m., Carlos da Silva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Carlos da Silva.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2011, 10:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Porting the mymoneymoney class to AlkValue (from alkimia) in order to deal with overflows (Bug 245214).
Requires the installation of the following packages:
- libalkimia
- GMP library (http://gmplib.org/).
Notes about the development of the patch are in http://community.kde.org/KMyMoney/PlayingWithAlkValue.
This is an updated version using the latest libalkimia and revision r1213144 of kmymoney.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Passed all unit tests present in the code.
I have been using this patch with two of my real files, and tested with the files posted in the bug description.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=245214">245214</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/CMakeLists.txt <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/cmake/modules/FindLibalkimia.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/converter/mymoneyqifreader.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/converter/webpricequote.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/dialogs/knewequityentrydlg.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/dialogs/transactionmatcher.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyforecasttest.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.h <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.h <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyutils.h <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyutils.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/parsedatatest.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/icalendarexport/CMakeLists.txt <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/icalendarexport/schedulestoicalendar.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/CMakeLists.txt <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/kbanking/mymoneybanking.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/ofximport/CMakeLists.txt <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/CMakeLists.txt <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/numbertowords.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/printcheck/printcheck.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/reconciliationreport/CMakeLists.txt <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/reconciliationreport/reconciliationreport.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/reports/pivottabletest.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/reports/querytable.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kaccountsview.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kbudgetview.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kcategoriesview.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kforecastview.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/khomeview.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kinstitutionsview.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kscheduledview.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/widgets/transaction.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/durationwizardpage.cpp <span style="color: grey">(1222953)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/knewloanwizard.cpp <span style="color: grey">(1222953)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5310/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>