<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5404/">http://svn.reviewboard.kde.org/r/5404/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;d say commit it, and we&#39;ll add on top of this. It&#39;s much easier to add more features when this is already commited.</pre>
 <br />







<p>- Alvaro</p>


<br />
<p>On December 26th, 2010, 5:47 p.m., Fernando Vilas wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for kmymoney.</div>
<div>By Fernando Vilas.</div>


<p style="color: grey;"><i>Updated 2010-12-26 17:47:56</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initial cut at the balance cache for the MyMoneyFile layer. Nothing uses it other than the test driver yet, but that will change once this is committed. Does it have a reasonable interface? Does it need something else added, like a model interface?

This interface is subject to change for now, but should be stable enough to start the next phase if it does not need revision first.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built test driver, and the object passes all tests. Hooray, test-driven-development</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt <span style="color: grey">(1209433)</span></li>

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecachetest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecachetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(1209433)</span></li>

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(1209433)</span></li>

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/imymoneystorage.h <span style="color: grey">(1209433)</span></li>

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgr.h <span style="color: grey">(1209433)</span></li>

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp <span style="color: grey">(1209433)</span></li>

 <li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.cpp <span style="color: grey">(1209433)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5404/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>