<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6238/">http://svn.reviewboard.kde.org/r/6238/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 4th, 2011, 3:51 p.m., <b>Cristian Onet</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Commit it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done.
Committed revision 1211724.</pre>
<br />
<p>- Allan</p>
<br />
<p>On December 30th, 2010, 7:05 p.m., Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated 2010-12-30 19:05:47</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wish-list Items:
Addition of UI text delimiter (" or ').
Addition of handling of line breaks within payee and memo fields.
Addition of handling of amount sign via a code in another field.
Bug fixes:
A much as possible, I've tried to preserve the user's column choices. With further testing and
live work, it was found that column choices from one file, could, in some circumstances, adversely
affect a following file having a different format. This in two cases led to KMM crashing or stack
corruption, through indexes going out of range. It was necessary to drop the preservation of memo
column settings between files, as the memo field is optional and not guaranteed to be wanted for
the following file. Also, better range checking of column choices.
Improved detection of conflicting columns during repeated changing of selections.
A couple of translation issues addressed.
Improvement:
Allow dates with no separators to be handled.
Tidy up (with white space changes, I'm afraid.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Intensive stress testing of UI column choices. Many different format files used. Unit test improved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp <span style="color: grey">(1210268)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlgdecl.ui <span style="color: grey">(1210268)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6238/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>