<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5189/">http://svn.reviewboard.kde.org/r/5189/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 2nd, 2010, 8:42 a.m., <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry to jump a bit late into the review.
This is not enough AFAICT. The use case to support is to have multiple accounts per institution per payee. I have multiple accounts at various banks each so this does not help at all because the fields will be overridden each time I do a download. Or am I missing something?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought, one payee is bound to one account. This is the case it 99.9 % of my transactions. That would allow me to choose a payee and start a wire transfer (this is on my todo list). The second cause for me to implement this is the current payee matching algorithm, which is very fuzzy. HBCI gives you the info for free, and we should store it some where.
Would a list of associated bank code numbers / account number per payee help?</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On September 2nd, 2010, 8:22 a.m., Sebastian Held wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Sebastian Held.</div>
<p style="color: grey;"><i>Updated 2010-09-02 08:22:00</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please refer to BUG 249403 (new payee fields: bank code number and account number)
This patch includes the database changes. I'm not sure, if I got the db stuff right.
This review board didn't accept my git diffs... Thus the diff is created by post-review; I hope it's complete.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=249403">249403</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayee.h <span style="color: grey">(1169309)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayee.cpp <span style="color: grey">(1169309)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneydbdef.cpp <span style="color: grey">(1169309)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.h <span style="color: grey">(1169309)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.cpp <span style="color: grey">(1169309)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kpayeesview.cpp <span style="color: grey">(1169309)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/views/kpayeesviewdecl.ui <span style="color: grey">(1169309)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5189/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>