<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4520/">http://reviewboard.kde.org/r/4520/</a>
</td>
</tr>
</table>
<br />
<pre>If it is possible to do a #ifdef KDE4_BUILD_TESTS / #endif or similar around the friend declaration, I would prefer that. If not, then it looks good to me. In an effort to reduce the friend declarations, we should probably have a more in depth look at the tests after this is committed.</pre>
<br />
<p>- Fernando</p>
<br />
<p>On July 3rd, 2010, 6:10 p.m., Cristian Onet wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Cristian Onet.</div>
<p style="color: grey;"><i>Updated 2010-07-03 18:10:15</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Replace the '#define' of all access qualifiers to public with proper 'friend class' declarations for unit tests. I know that this replaces the non-intrusive way of writing unit tests with a relatively intrusive way (if you can call the friend class declaration as such) but this should be done to fix the following linkage problem. Some compilers (like msvc) include the access qualifiers in the mangled method name so when we try to link the unit test we will fail because we are looking for a public method in a library where that method is actually private or protected. It took me a while to spot this error and I think we should really fix it. I don't see a problem with the fact that the unit test class is a friend of the real class. Any thoughts? Another solution would mean recompiling the mymoney cpp files and linking them in the test executable but I don't like this solution.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/extragear/office/kmymoney/kmymoney/converter/convertertest.cpp <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyaccount.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyaccounttest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyaccounttest.cpp <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyexceptiontest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfiletest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfinancialcalculator.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfinancialcalculatortest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyforecast.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyforecasttest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyinstitutiontest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneykeyvaluecontainer.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneykeyvaluecontainertest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoney.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyobject.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyobjecttest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayeetest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypricetest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyscheduled.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyscheduletest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneysecuritytest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneysplittest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneytransaction.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneytransactiontest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgr.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneymaptest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgr.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/reports/pivotgrid.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/reports/pivotgridtest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/reports/pivotgridtest.cpp <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/reports/pivottable.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/reports/pivottabletest.h <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/reports/pivottabletest.cpp <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/reports/querytabletest.cpp <span style="color: grey">(1145134)</span></li>
<li>trunk/extragear/office/kmymoney/kmymoney/reports/reportstestcommon.cpp <span style="color: grey">(1145134)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4520/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>