<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4417/">http://reviewboard.kde.org/r/4417/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 23rd, 2010, 2:30 a.m., <b>Fernando Vilas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>I can confirm that the database backend is affected. However, the patch does not seem to help. There may be a larger issue with the UI not updating while the home page is loading. The progress bar only updates occasionally, so it is hard to tell if the patch works or not.</pre>
</blockquote>
<p>On June 24th, 2010, 12:56 p.m., <b>Alvaro Soliverez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>Fernando, do you think there is a quick fix for the DB code or should we ship this patch without the DB part?</pre>
</blockquote>
</blockquote>
<pre>I would say ship it without the DB part. It does not look like a quick fix at all. We should work to resolve it prior to release, but it is less critical (in my mind) than Qt3Support, so we could even ship with this in the "known issues" section of the release notes.</pre>
<br />
<p>- Fernando</p>
<br />
<p>On June 22nd, 2010, 12:46 p.m., Vincent Ordy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Vincent Ordy.</div>
<p style="color: grey;"><i>Updated 2010-06-22 12:46:36</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">- set progressbar value to 0 after a reset (reset() sets it to -1, which is
invalid and cause this bug)
- increment the progressbar value only when appropriate. Some elements like <budgets> do not initialize the progressbar, but the progressbar value was incremented => the value become greater than the maximum => the progressbar is reset by Qt.
- remove useless resets</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">build + load 2 files w/ the progressbar timer disabled (kmymoney/kmymoney.cpp:1932) to slow down the progress</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=240629">240629</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp <span style="color: grey">(1140640)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.cpp <span style="color: grey">(1140640)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragexml.cpp <span style="color: grey">(1140640)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneymvccombo.cpp <span style="color: grey">(1140640)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4417/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>