<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4408/">http://reviewboard.kde.org/r/4408/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 21st, 2010, 10:55 a.m., <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>I ran the patch with CPPUNIT uninstalled and did not have any problems here. I build in an existing build environment as well as a fresh new one without any problems.
The only difference I noticed is that the total number of tests shown to the user/developer dropped from 332 to 22.</pre>
</blockquote>
<p>On June 22nd, 2010, 12:36 a.m., <b>Fernando Vilas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>CPPUNIT counts every test function. QTest counts every test class, analogous to the CPPUNIT test suites.</pre>
</blockquote>
</blockquote>
<pre>Remember to mark this one as submitted, as it is already in SVN.</pre>
<br />
<p>- Alvaro</p>
<br />
<p>On June 20th, 2010, 3:16 p.m., Fernando Vilas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Fernando Vilas.</div>
<p style="color: grey;"><i>Updated 2010-06-20 15:16:16</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch removes the dependency on CPPUNIT for the unit tests. As part of that, there is no longer a kmymoneytest executable created. The tests are all individual and can be executed with "make test", or called individually.
Most of the port is s/CPPUNIT_FAIL/QFAIL/g and s/CPPUNIT_ASSERT/QVERIFY/g.
The web quotes test has an example of data driven testing, which we may use more in later unit test updates.
The patch is fairly large, so I want some others to review it before I commit.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">All tests were ported, and remain passing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/CMakeLists.txt <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/converter/CMakeLists.txt <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/converter/convertertest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/converter/convertertest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/kmymoneytest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/main.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyaccounttest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyaccounttest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyexceptiontest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyexceptiontest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfiletest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfiletest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfinancialcalculatortest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfinancialcalculatortest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyforecasttest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyforecasttest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyinstitutiontest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyinstitutiontest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneykeyvaluecontainertest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneykeyvaluecontainertest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneymoneytest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyobjecttest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyobjecttest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayeetest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayeetest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypricetest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypricetest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyscheduletest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyscheduletest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneysecuritytest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneysecuritytest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneysplittest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneysplittest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneytestutils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneytransactiontest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneytransactiontest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyutils.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/CMakeLists.txt <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneymaptest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneymaptest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgrtest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/reports/CMakeLists.txt <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/reports/kreportsviewtest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/reports/pivotgridtest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/reports/pivotgridtest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/reports/pivottabletest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/reports/pivottabletest.cpp <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/reports/querytabletest.h <span style="color: grey">(1140349)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/reports/querytabletest.cpp <span style="color: grey">(1140349)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4408/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>