<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4417/">http://reviewboard.kde.org/r/4417/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 22nd, 2010, 9:27 a.m., <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>I understand and support the changes to the XML backend, but I don't know if we really need a progress bar for the SQL backend. In case we do, please replace QObject::tr with a call to KDE's i18n function.
I noticed two things in the XML backend changes:
int count = atts.value(QString("count")).toUInt();
a) Why do you use an "int" and assign it an "unsigned int"?
b) Using QLatin1String("count") is better than QString("count")
Details for b) can be found on http://labs.trolltech.com/blogs/2008/04/28/string-theory/</pre>
</blockquote>
</blockquote>
<pre>This line is a copy of lines 167, 174, 181, 188, and 195 that were already there. I should have payed attention though. Thanks for the pointer on QLatin1String.
I'm going to update the patch to fix that.
Alvaro asked me on bugzilla if the database storage was affected by the progress bar bug so I fixed it, but I really don't mind if you drop it (I've never even used the SQL storage before).</pre>
<br />
<p>- Vincent</p>
<br />
<p>On June 22nd, 2010, 4:58 a.m., Vincent Ordy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kmymoney.</div>
<div>By Vincent Ordy.</div>
<p style="color: grey;"><i>Updated 2010-06-22 04:58:04</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">- set progressbar value to 0 after a reset (reset() sets it to -1, which is
invalid and cause this bug)
- increment the progressbar value only when appropriate. Some elements like <budgets> do not initialize the progressbar, but the progressbar value was incremented => the value become greater than the maximum => the progressbar is reset by Qt.
- remove useless resets</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">build + load 2 files w/ the progressbar timer disabled (kmymoney/kmymoney.cpp:1932) to slow down the progress</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=240629">240629</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp <span style="color: grey">(1140640)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.cpp <span style="color: grey">(1140640)</span></li>
<li>/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragexml.cpp <span style="color: grey">(1140640)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4417/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>