<br><br><div class="gmail_quote">On Sun, Sep 13, 2009 at 11:26 PM, Fernando Vilas <span dir="ltr"><<a href="mailto:fvilas@iname.com">fvilas@iname.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
I have made some progress on getting quotes working again, but I have a few<br>
questions that hopefully can be answered by someone who understands this<br>
object better than I do.<br>
<br>
There are several code paths for non-interactive executables, controlled by<br>
checking "if (! kapp)". kapp is always true, whether it is set to false in<br>
main() in kmymoney2/kmymoneytest.cpp or not. In the interest of simplicity<br>
and testability, I would like to remove these paths, leaving only the path<br>
followed when kapp is true. This also fixes the "fix for windows" warning in<br>
WebPriceQuote::launchNative(). Any objections, or things I should consider?<br>
<br>
WebPriceQuote::launchNative() has a branch for executing a local file. There<br>
is a separate class for handling the Perl Finance::Quote script, so I don't<br>
really know how to test this branch. Does anyone have an example, or would<br>
you suggest removing this branch, and creating a class similar to the one for<br>
Finance::Quote if/when more scripts are added?<br>
<br>
WebPriceQuote::download() and related functions are private, and a<br>
reimplementation of parts of KIO::NetAccess. Before I change the code to just<br>
call KIO::NetAccess::download(), does the original reason for the<br>
reimplementation still make sense? So far, I have commented out the bulk of<br>
WebPriceQuote::download(), and just call the NetAccess version internally.<br>
<br>
As of right now, things seems to be working, both in the test driver, and the<br>
main app. The test driver retrieves from Yahoo (US, UK, Currency), and<br>
Finance::Quote, but fails on the Globe & Mail and MSN. I have not built tests<br>
for the remaining sources, but I probably will, just to make things easier in<br>
the future.<br>
<br>
If you want to see the changes, I can send a patch, or go ahead and commit the<br>
changes. Don't forget to define PERFORM_ONLINE_TESTS, to see these tests.<br>
<font color="#888888"><br>
</font></blockquote></div><br>Thomas may have the best info about this. <br>@Thomas, do you remember why any of these decisions were made at the time? Were you involved in any of this back then?<br>I know there are some things in reports which I would have done differently, so this might be the case.<br>
<br>If Thomas doesn't remember, Fernando, you can reassess, make sure the test cases cover enough of the practical cases and go with your solution.<br><br>Regards,<br>Alvaro<br>