[Kmymoney-devel] [Kmymoney2-developer] Broken QT4 build?

[Fernando Vilas]

On Tuesday 06 October 2009 08:31:11 Cristian Oneţ wrote:
> On Tue, Oct 6, 2009 at 4:23 PM, Alvaro Soliverez <asoliverez at gmail.com> 
wrote:
> > On Tue, Oct 6, 2009 at 11:06 AM, Fernando Vilas <fvilas at iname.com> wrote:
> >> On Monday 05 October 2009 22:22:15 Alvaro Soliverez wrote:
> >> > On Mon, Oct 5, 2009 at 11:47 PM, Fernando Vilas <fvilas at iname.com>
> >> >
[...]
> >> > > I overlooked that last time.  I will convert the KButtonGroups to
> >> > > QGroupBoxes
> >> > > with QButtonGroup attributes on the buttons.  That should be more
> >> > > portable, since a lot of distros haven't upgraded to KDE 4.3 yet.
> >> >
> >> > Is there a way to keep the KButtonGroups but use a different method?
> >> > We had
> >> > problems with the QGroupBoxes before, because the API is very
> >> > different from the Qt3 one.
> >>
> >> After sleeping on this, I realized that KButtonGroup derives from
> >> QGroupBox,
> >> so we have to deal with the API change regardless.  I would still like
> >> to do
> >> something simple, but don't be surprised if it comes down to doing a
> >> QGroupBox
> >> with QButtonGroup buttons.  I'll try to get something going on this
> >> tonight,
> >> since I really don't like having code in SVN that only compiles for some
> >> users.
> >
> > We have not settled on the KDE version required for KMM4, and KDE 4.3 is
> > the one I see as being user-ready. 4.2 was close to that, but still
> > buggy, so most distributions will go for 4.3 in the short term. Also, the
> > next releases for Fedora, Kubuntu and Mandriva are just a month or so
> > away, so it is not such a terrible thing.
> >
> > So, from my point of view, if it involves too much work to fix it for
> > pre-4.3 users, leave it that. We are still at the "It will eat your home
> > pets and run away" stage for KMM4.
> 
> I totally agree with Alvaro on this.
> 

Long version: I ended up changing it to a QGroupBox after all.  KButtonGroup 
subclasses it to add features related to the buttons contained in it.  By 
using a QGroupBox and managing the buttons with a QButtonGroup, we get all the 
button management features, plus the ability to change the QGroupBox to 
something else without affecting the buttons.  If we do have to change away 
from QGroupBox for the whole project, we'll have to remember to change the 
other KButtonGroup instances as well.

Short version: fixed in SVN, and we can change the QGroupBox at need without 
breaking stuff.

I disagree that the minimum version should be 4.3.  Slackware 13 just came 
out, using KDE 4.2, so I'm biased.  I built 4.3 on my own to get to play with 
the new features before slackware-current gets going again.

-- 
Thanks,
Fernando Vilas
fvilas at iname.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kmymoney-devel/attachments/20091006/c5daea26/attachment.sig