<div dir="ltr"><div>Hey all,</div><div><br></div><div>Since Dmitry is on vacation, I am writing here because I needed to clarify a few things. I wanted to a<span id="gmail-docs-internal-guid-b13329a7-7fff-991d-10be-c37413b3df89"><span style="font-family:Arial;color:rgb(40,41,42);font-variant-numeric:normal;font-variant-east-asian:normal;vertical-align:baseline;white-space:pre-wrap">dd support for Perspective Ellipse in Krita as a part of Season of KDE.</span></span></div><div><span><span style="font-family:Arial;color:rgb(40,41,42);font-variant-numeric:normal;font-variant-east-asian:normal;vertical-align:baseline;white-space:pre-wrap">The link for the feature request: </span></span><a href="https://bugs.kde.org/show_bug.cgi?id=405643">Circle in a Square </a></div><div><br></div><div><span id="gmail-docs-internal-guid-103850c6-7fff-17eb-615f-0038157871b0"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-variant-numeric:normal;font-variant-east-asian:normal;vertical-align:baseline;white-space:pre-wrap">Now, I wanted to clarify if this is roughly what I would be doing. </span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-variant-numeric:normal;font-variant-east-asian:normal;vertical-align:baseline;white-space:pre-wrap"><br></span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-variant-numeric:normal;font-variant-east-asian:normal;vertical-align:baseline;white-space:pre-wrap">1. Create a seperate button on Tools Option Docker for Ellipse Tool. </span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-variant-numeric:normal;font-variant-east-asian:normal;vertical-align:baseline;white-space:pre-wrap">2. When the perspective ellipse button is clicked, a circle in a square figure appears on the canvas, the corners of the squares being adjustable. The circle in a square can be moved to the desired location and corners can be adjusted. 3. Now when the corners are adjusted, I need to use the </span><span style="color:rgb(0,0,0);font-family:Arial;white-space:pre-wrap">KisPerspectiveTransformStrategy::</span><span style="background-color:transparent;color:rgb(0,0,0);font-family:Arial;white-space:pre-wrap">continuePrimaryAction() function to get the transformation matrix from the four points and use that to transform the circle to the corresponding ellipse. </span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="background-color:transparent;color:rgb(0,0,0);font-family:Arial;white-space:pre-wrap">4. As Halla suggested, this transformation should not transform the pixels, so I probably need to look into what other methods are there for transforming. </span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="background-color:transparent;color:rgb(0,0,0);font-family:Arial;white-space:pre-wrap">5. As for the mathematical part, I can use the transformation matrix on the old circle/ellipse to convert it to the new ellipse, but the </span><span style="color:rgb(0,0,0);font-family:Arial;white-space:pre-wrap">KisAlgebra2d::</span>transformEllipse<span style="background-color:transparent;color:rgb(0,0,0);font-family:Arial;white-space:pre-wrap">() function uses the semimajor and semiminor axes lengths, so would it possible to reuse that function by finding the major and minor axes? </span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="background-color:transparent;color:rgb(0,0,0);font-family:Arial;white-space:pre-wrap">6. Also, just to be clear, I am extending the Ellipse Tool, not creating another Assistant Tool(there is one Ellipse option in the Assistant Tool as well), right?</span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="background-color:transparent;color:rgb(0,0,0);font-family:Arial;white-space:pre-wrap"><br></span></p><p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="background-color:transparent;color:rgb(0,0,0);font-family:Arial;white-space:pre-wrap">I have created a draft proposal which was reviewed by Halla earlier. The details have been mentioned there. Link: </span><a href="https://docs.google.com/document/d/1Bgi0og-YMkyU8rmVr9RuXyzi6f4YLretYk-HFSkG-d4/edit?usp=sharing">Draft Proposal</a></p><p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><br></p><p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><font color="#000000" face="Arial"><span style="white-space:pre-wrap">With regards,</span></font></p><p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><font color="#000000" face="Arial"><span style="white-space:pre-wrap">Srirupa Datta</span></font></p><p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><font color="#000000" face="Arial"><span style="white-space:pre-wrap">IRC: </span></font><span style="font-family:Arial;font-size:10.5pt;white-space:pre-wrap">sriru:<a href="http://matrix.org">matrix.org</a></span></p></span><br class="gmail-Apple-interchange-newline"></div></div>