<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<font size="-1">Hi, Jouni!<br>
<br>
While Phabricator is down I'll post the review here :)<br>
<br>
I have tested the patch and it has at least two regressions:<br>
<br>
1) It crashes when there is no audio attached (see a patch in
attachement that should fix that):<br>
2) When in drop frames mode, the video does not always cycle in
the end of the clip. Basically, sometimes video just "jumps over"
the end of the selection or the clip range. To test that you can
do the following:<br>
<br>
i) create a big image (with or without sound)<br>
ii) select several frames, e.g. 5-30th frames<br>
iii) start play<br>
iv) playback will jump over the 30th frame and will continue to
the infinity<br>
<br>
<br>
</font>
<pre class="moz-signature" cols="72">--
Dmitry Kazakov</pre>
</body>
</html>