<div dir="ltr">It might be somehow related to the fact that Boud used to optimize Krita saving code. Probably, disabling the internal PNG compression made the speed much higher? Boud?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 6, 2016 at 9:11 PM, Alvin Wong <span dir="ltr"><<a href="mailto:alvinhochun+krita@gmail.com" target="_blank">alvinhochun+krita@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">About the mergedimage.png, I see that the png itself isn't compressed<br>
at all, only compressed by DEFLATE inside the zip container. For a<br>
completely-transparent image of 3600x2400, the mergedimage.png is 33MB<br>
uncompressed, which is ridiculous. It's 55KB compressed, much smaller,<br>
but still a bit larger than expected.<br>
<br>
Would compressing the png itself and STORE it inside the zip container<br>
instead be better? Might want to benchmark and compare.<br>
<div class="HOEnZb"><div class="h5"><br>
2016-06-07 0:59 GMT+08:00 Boudewijn Rempt <<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>>:<br>
> On Mon, 6 Jun 2016, Dmitry Kazakov wrote:<br>
><br>
>> The only trouble I see with thumbnail generation is the speed. It would be<br>
>> great to see the speen benchmarks of saving a PNG of each size.<br>
><br>
><br>
> Well that needs checking indeed.<br>
><br>
>> People are complaining<br>
>> about Krita saving too slow :( I even heard a wish (during the KomMissia)<br>
>> to disable any preview and mergedimage.png saving into .kra to make the<br>
>> saving quicker.<br>
><br>
><br>
> That's just flat-out not going to happen.<br>
><br>
><br>
>><br>
>><br>
>><br>
>><br>
>> On Mon, Jun 6, 2016 at 3:44 PM, Boudewijn Rempt <<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>> wrote:<br>
>> On Mon, 6 Jun 2016, Alvin Wong wrote:<br>
>><br>
>> Is that needed? I would imagine whatever plugins or programs<br>
>> would<br>
>> already have known the absolute size they want in pixels,<br>
>> independent<br>
>> of the dpi, and could just automatically take the closest<br>
>> thumbnail or<br>
>> the mergedimage and scale it down accordingly.<br>
>><br>
>><br>
>> I don't know... Hidpi and Retina is still really confusing me across<br>
>> the board.<br>
>><br>
>> Perhaps you can also add a thumbnail of size 2048x2048 but I<br>
>> wonder<br>
>> how much it would add to the file size...<br>
>><br>
>> By the way I remember seeing in the Krita git repo some<br>
>> scripts which<br>
>> look like plugins for certain programs to extract the<br>
>> thumbnail, but I<br>
>> can't seem to find them now. Does anyone know, other than the<br>
>> Windows<br>
>> shell extension, what other file managers or programs<br>
>> currently<br>
>> supports extracting thumbnails from Krita files/<br>
>><br>
>><br>
>> Code for Qt applications is in the kimageformats repo now, I moved<br>
>> that some time ago. There are also scripts for nautilus and gnome.<br>
>><br>
>><br>
>> Best Regards,<br>
>><br>
>> Alvin<br>
>><br>
>><br>
>> 2016-06-06 14:54 GMT+08:00 Boudewijn Rempt <<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>>:<br>
>> I think we can easily do this: but maybe we should at<br>
>> the same time<br>
>> add thumbnails with a @2 extension to prepare for hidpi<br>
>> and retina<br>
>> displays?<br>
>><br>
>><br>
>> On Mon, 6 Jun 2016, Alvin Wong wrote:<br>
>><br>
>> Hi,<br>
>><br>
>> I would like to suggest Krita add (uncropped)<br>
>> thumbnail images of<br>
>> different sizes to the file to allow faster<br>
>> extraction of thumbnails<br>
>> by external applications.<br>
>><br>
>> There is currently one preview.png which is at<br>
>> maximum 256x256, so<br>
>> generating thumbnails larger than that would<br>
>> require scaling down from<br>
>> the mergedimage.png which could be very large and<br>
>> may take a<br>
>> comparatively long time to process. Even though<br>
>> the actual time per<br>
>> file might not be much, it could add up for a lot<br>
>> of files.. Also, the<br>
>> preview.png is cropped to the non-transparent<br>
>> region<br>
>> (<a href="https://bugs.kde.org/show_bug.cgi?id=363968" rel="noreferrer" target="_blank">https://bugs.kde.org/show_bug.cgi?id=363968</a>)<br>
>> which makes things a bit<br>
>> weird and inconsistent.<br>
>><br>
>> I think having thumbnails for the sizes<br>
>> (maintaining aspect ratio) of<br>
>> 256x256 and 1024x1024 would suffice, but boud<br>
>> suggested having 512x512<br>
>> might be nice too. Adding in these sizes means<br>
>> that, for thumbnails<br>
>> equal to or below the available sizes, they can be<br>
>> extracted and<br>
>> optionally scaled down from those instead of<br>
>> scaling down from the<br>
>> mergedimage.png. Obviously, sizes larger than that<br>
>> would still require<br>
>> using the mergedimage.png, but hopefully it would<br>
>> be quite rare for an<br>
>> application to request for thumbnails larger than<br>
>> 1024x1024... (4K<br>
>> displays aren't popular yet... right?)<br>
>><br>
>> For the record, according to this MSDN page<br>
>><br>
>><br>
>> (<a href="https://msdn.microsoft.com/en-us/library/windows/desktop/cc144118(v=vs.85).aspx" rel="noreferrer" target="_blank">https://msdn.microsoft.com/en-us/library/windows/desktop/cc144118(v=vs.85).aspx</a>)<br>
>> Windows asks for the sizes 32/96/256/1024.<br>
>><br>
>> I am asking for this as the developer of the<br>
>> Windows Shell Extension.<br>
>><br>
>> Any suggestions?<br>
>><br>
>> Best Regards,<br>
>><br>
>> Alvin<br>
>> _______________________________________________<br>
>> Krita mailing list<br>
>> <a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
>> <a href="https://mail.kde.org/mailman/listinfo/kimageshop" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
>><br>
>><br>
>><br>
>> --<br>
>> Boudewijn Rempt | <a href="http://www.krita.org" rel="noreferrer" target="_blank">http://www.krita.org</a>,<br>
>> <a href="http://www.valdyas.org" rel="noreferrer" target="_blank">http://www.valdyas.org</a><br>
>> _______________________________________________<br>
>> Krita mailing list<br>
>> <a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
>> <a href="https://mail.kde.org/mailman/listinfo/kimageshop" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
>><br>
>> _______________________________________________<br>
>> Krita mailing list<br>
>> <a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
>> <a href="https://mail.kde.org/mailman/listinfo/kimageshop" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
>><br>
>><br>
>> --<br>
>> Boudewijn Rempt | <a href="http://www.krita.org" rel="noreferrer" target="_blank">http://www.krita.org</a>, <a href="http://www.valdyas.org" rel="noreferrer" target="_blank">http://www.valdyas.org</a><br>
>> _______________________________________________<br>
>> Krita mailing list<br>
>> <a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
>> <a href="https://mail.kde.org/mailman/listinfo/kimageshop" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
>><br>
>><br>
>><br>
>><br>
>> --<br>
>> Dmitry Kazakov<br>
>><br>
>><br>
><br>
> --<br>
> Boudewijn Rempt | <a href="http://www.krita.org" rel="noreferrer" target="_blank">http://www.krita.org</a>, <a href="http://www.valdyas.org" rel="noreferrer" target="_blank">http://www.valdyas.org</a><br>
> _______________________________________________<br>
> Krita mailing list<br>
> <a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/kimageshop" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
_______________________________________________<br>
Krita mailing list<br>
<a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Dmitry Kazakov</div>
</div>