<div class="gmail_quote">On Sun, Jul 8, 2012 at 4:39 PM, T Hall <span dir="ltr"><<a href="mailto:tahall256@gmail.com" target="_blank">tahall256@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Sven,<br>
<br>
I've just compiled your branch and given it a quick test. These are my<br>
observations so far:<br>
<div class="im"><br>
> - tools can be changed even if the active layer is locked/invisible,<br>
> no longer grayed out (unless it's a shape layer)<br>
</div>Seems to work fine.<br>
<div class="im">> - cursor/brush outline is still shown when the layer is<br>
> locked/invisible<br>
</div>Works fine.<br>
<div class="im">> - selections can be edited even if the current layer is locked, unless<br>
> there is a locked local selection<br>
</div>Selection tools work. However, there are a couple of functions<br>
(Deselect, Reselect and, Invert Selection), which aren't allowed on<br>
locked layers (Greyed-out in menu, shortcuts do nothing). Since these<br>
functions only edit selections, and don't affect the layer, I think<br>
they should be allowed when the selected layer is locked.<br><div class="im"></div></blockquote><div><br>Fixed, now just depends on the selection state.<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im">
> - if the user tries to paint on a locked layer, Krita will show a<br>
> small notification<br>
</div>Works fine. However, no notification is shown if the user tried to edit<br>
the via a shortcut. e.g. pressing backspace to fill the layer with the<br>
foreground colour (the application behaves correctly, in that it<br>
doesn't allow the layer to be filled, it's only the notification<br>
that's missing). I think it would be nice if the notification appeared<br>
for such actions. (I haven't looked at how locking a layer<br>
disables/blocks shortcuts/actions like this, so don't know how<br>
difficult it would be to implement this)<br>
<br>
Additionally:<br>
Items from the "Layer" menu (Mirror Horizontally, Mirror<br>
Vertically, Shear Layer, Scale Layer, Rotate..., Convert Layer Type)<br>
are still available for use on locked layers. Most of these are<br>
destructive (not revertable except via undo), so definitely shouldn't be<br>
allowed on locked layers.<br></blockquote><div><br>This is kind of a problem. In KDE it usual that if the action is disabled menu entry and shortcut are disabled. So we could either have a notification or disable the menu entry. Not sure what to do there.<br>
<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
The transform tool also exhibits some odd behaviour (What's new :p). It<br>
allows you to make the transformation, as long as you don't apply it<br>
(Seems reasonable). However, when you try to apply it (and get the<br>
"Layer is locked" notification), it returns all the handles to their<br>
original position.<br>
1. It appears you can't keep your transformation and either carry on<br>
transforming or unlock the layer then apply it (if you really meant to<br>
do the transformation, but forgot to unlock the layer first).<br>
2. Actually, if (before attempting further transformation) you switch<br>
to another tool, then switch back to the transform tool, then your<br>
transformation reappears as it was before you tried to apply it<br>
(allowing you to carry on transforming, or unlock and apply).<br>
<br>
I believe correct behaviour should be:<br>
When you try to apply the transformation, handles remain in their<br>
transformed position, allowing you to continue working with the<br>
transformation (without having to switch to another tool and back).<br></blockquote><div><br>Fixed, handles remain now.<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I haven't tested it exhaustively, but those I did test suggest that<br>
all of the above applies not only to locked layers, but also to<br>
invisible layers, and locked and invisible layers.<br>
<br>
One more minor issue: If I create a group layer containing other layers<br>
and lock the group layer, but not the layers inside it:<br>
1. It won't let me edit the layers inside. This is correct behaviour.<br>
2. The notification says "Layer is invisible", regardless of whether the<br>
group layer is locked, invisible or locked and invisible.<br></blockquote><div><br>Fixed, now it shows a message "Group is not editable".<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Probably unrelated: I notice I can't make a selection when the<br>
group layer is selected, be it unlocked or locked. Following the logic<br>
of selection tools do not edit the selected layer, perhaps they should<br>
be allowed? This could also be related to allowing the transform tool<br>
to transform multiple layers at the same time by operating on a group<br>
layer (feature request detailed in bug 297927). Anyway, I don't think<br>
this is related to 'lockedness' or specific to your branch, so I guess<br>
it's offtopic in this email.<br>
<br></blockquote><div><br>Fixed.<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
So to summarise:<br>
- Selection functions disallowed<br>
- No notifications shown for shortcuts/menu actions<br>
- Items from the Layer menu allowed to edit locked layers<br>
- Transform tool oddities<br>
- Incorrect notification for group layer locked<br>
<br>
Hope that helps.<br>
</blockquote></div><br>It did :). Thanks a lot for the detailed testing.<br>