<div class="gmail_quote">On Sat, Jul 2, 2011 at 3:27 PM, JL VT <span dir="ltr"><<a href="mailto:pentalis@gmail.com">pentalis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Trying to fix Bug 232141 I found other problems with the layer properties, for example when setting the blue channel off it's as if deactivating the red channel, and changing red is like changing blue.<div><br></div><div>
I noticed that this bug is not present in the new Channel Docker that Slangkamp made, based on his ChannelModel, and that KisChannelFlagsWidget is only used in KisDlgLayerProperties, which is the dialog for layer properties (right click --> Properties...), then one I was trying to fix.</div>
<div><br></div><div>Since the Model/View architecture is a more general solution, and I know the reversed bug affecting channels is not affecting ChannelModel, I propose renaming ChannelModel to KisChannelModel and moving it to krita/ui/ , and deleting KisChannelFlagsWidget since it is completely replaced by ChannelModel, which I plan to use in KisDlgLayerProperties (displayed in the form of a QTableView).</div>
<div><br></div><div>Thoughts?. Sounds good?, Sounds bad?.</div></blockquote><div><br>Should be easy to fix the bug. When saving the flag it needs to use the channel position in the channels() list and not the index of the channel. That's because the channels in the channels list are ordered as BGRA but in the pixels they are RGBA. <br>
</div></div>