<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
On 01/10/2011 11:16 PM, JL VT wrote:
<blockquote
cite="mid:AANLkTi=1emVkDQs4vK0csGg-9brx=F8EdOnG7rexjNBk@mail.gmail.com"
type="cite">Silvio, I downloaded your patch and added it to a git
branch called
<div><br>
</div>
<div>krita-fixsmudgebrush-silvioheinrich</div>
<div>
<div>
<div><br>
</div>
<div>It's available in the remote repository (the master) such
that others can check it out and play with it.</div>
</div>
</div>
</blockquote>
Oh, that's cool :D<br>
<br>
<br>
<blockquote
cite="mid:AANLkTi=1emVkDQs4vK0csGg-9brx=F8EdOnG7rexjNBk@mail.gmail.com"
type="cite">
<div>
<div>
<div>I noticed a problem with your version of the brush,
slightly transparent colors quickly become opaque:</div>
<div><a moz-do-not-send="true"
href="http://imagebin.org/132048">http://imagebin.org/132048</a></div>
<div><br>
</div>
<div>That doesn't give the impression of smudging very much.
This is a problem the old brush had to an extent, but it was
mostly about the darkening (with black).</div>
</div>
</div>
</blockquote>
You are right. My smudge brush did build the color up to much/fast.<br>
This was bugging me all the time but it was due to the fact that i
only copied the opacity<br>
and not the colors too. But now i actually found out why the
KoCompositeOpCopy class<br>
was mixing the black color into everything and made it work as
expected.<br>
Now i use the COMPOSITE_COPY mode and the smudging behaves much
better :).<br>
<br>
<br>
<blockquote
cite="mid:AANLkTi=1emVkDQs4vK0csGg-9brx=F8EdOnG7rexjNBk@mail.gmail.com"
type="cite">
<div>
<div>
<div>I am also having difficulty replicating the "look" of the
old smudge brush defaults. Can you try to tune the defaults
of your new brush to look as identical as possible to the
defaults of the old smudge brush?, this will help avoiding
unfamiliar behavior.</div>
<div><br>
</div>
<div>I also want to ask you why did you remove this part of
the code? --></div>
<div><br>
</div>
<div>
<div> // Both limits defined to be 15 units away from
the min (0) or max (255) to allow actual mixing of colors</div>
<div> const quint8 MIXABLE_UPPER_LIMIT = 240;</div>
<div> const quint8 MIXABLE_LOWER_LIMIT = 15;</div>
</div>
<div><br>
</div>
<div>
<div> /* Without those limits, the smudge brush
doesn't smudge anymore, it either makes a single</div>
<div> dropplet of color, or drags a frame
indefinitely over the canvas. */</div>
<div> opacity = qBound(MIXABLE_LOWER_LIMIT, opacity,
MIXABLE_UPPER_LIMIT);</div>
</div>
</div>
</div>
</blockquote>
<blockquote
cite="mid:AANLkTi=1emVkDQs4vK0csGg-9brx=F8EdOnG7rexjNBk@mail.gmail.com"
type="cite">
<div>
<div>
<div><br>
</div>
<div>Is it because you put the limits in the controls or the
GUI, or is it because you deemed it unnecessary?</div>
<div><br>
</div>
<div>From my testing, I think it's because you thought it
was unnecessary, but I'll show you a case you can
test yourself:</div>
<div><br>
</div>
<a moz-do-not-send="true" href="http://imagebin.org/132050">http://imagebin.org/132050</a></div>
<div><a moz-do-not-send="true" href="http://imagebin.org/132051">http://imagebin.org/132051</a></div>
<div><br>
</div>
<div>With the old smudge brush, even at max rate, the brush
decolorates with time: it looks like a smudge.</div>
<div>With the new smudge brush (yours), at max rate (and even at
intermediate rates as long as you press hard with the tablet),
the "smudge" turns literally into a crayon, there's no
decoloration, the same shape the brush started with becomes
the one it ends with.</div>
<div>And also at low rate the brush doesn't smudge anything at
all.</div>
</div>
</blockquote>
Well i think the user should be able to choose from min. to max.
smudge rate.<br>
The absolute minimum is no smudge and the absolute maximum is
smudging without fading.<br>
But this is of course a matter of taste. We can set the minimum
smudge rate a bit above zero if you like.<br>
But the maximum smudge rate should stay at 100% because it gives
imho pretty nice effects<br>
when using 100% smudge rate and turning on the color option.<br>
I mainly removed this because i hate macros (:P) and hadn't
introduced any limitation functionality yet.<br>
Now you can limit the rates with the PressureRateOption and
PressureCompositeOption classes.<br>
<br>
<br>
<blockquote
cite="mid:AANLkTi=1emVkDQs4vK0csGg-9brx=F8EdOnG7rexjNBk@mail.gmail.com"
type="cite">
<div>
<div>I think you need to address that problem, if not with a
hardcoded limit, with a tweak to the controls (a tweak to the
controls is harder because tablet users also introduce a new
factor to watch out for: the curve), or with a logarithmic
curve or something, because currently it's very easy to cause
this smudge brush to behave nearly like a clone tool (as
displayed in my screenshot).</div>
<div><br>
</div>
<div><br>
</div>
<div>Other than that I think your brush is fine for me (I don't
know about the rest), since 2.4 is in development I think it
would be good if your brush could be added with a new name,
for example Smudge 2, such that artists can test it and
directly compare it with the old Smudge Brush, they will be
the first ones to notice any regression (because regressions
are hard to gauge anyway, sometimes what looks like an
advancement to someone will look like a regression to somebody
else).</div>
<div><br>
</div>
<div><br>
</div>
<div>Here is me hoping to see you around in the near future,</div>
<div>Thank you for your contributions!</div>
<div><br>
</div>
<div><br>
<div class="gmail_quote">On Mon, Jan 3, 2011 at 9:20 PM,
Silvio Heinrich <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:plassy@web.de">plassy@web.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">Now it should work pretty similar to
the smudge tool in gimp.<br>
But I still need to do some tweaks to how the rate values
(color and smudge rates) are used.<br>
It only smudges/paints correctly in a certain region of
the rates.<br>
But the transparency issues should be solved by now, so no
black color should be introduced anymore (hopefully :P).<br>
<br>
_______________________________________________<br>
kimageshop mailing list<br>
<a moz-do-not-send="true" href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a moz-do-not-send="true"
href="https://mail.kde.org/mailman/listinfo/kimageshop"
target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
kimageshop mailing list
<a class="moz-txt-link-abbreviated" href="mailto:kimageshop@kde.org">kimageshop@kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/kimageshop">https://mail.kde.org/mailman/listinfo/kimageshop</a>
</pre>
</blockquote>
<br>
So here is the newest version of the smudge brush and i hope there
are not to many flaws this time.<br>
I made the patch against origin/master. So I Don't know whether it
will apply correct on the branch or not. Maybe you have to reset the
branch<br>
or something? I'm not a git pro :D<br>
</body>
</html>