<div class="gmail_quote">On Wed, Sep 29, 2010 at 12:20 PM, <a href="mailto:LukasT.dev@gmail.com">LukasT.dev@gmail.com</a> <span dir="ltr"><<a href="mailto:lukast.dev@gmail.com">lukast.dev@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hi,<br>
<br>
here is the patch that enables the categories in the combo box.<br>
Would you please test it?<br>
<br>
I did testing and I did not found any regressions.<br>
<br>
There was some problem when colorspace change occur and<br>
the paintop does not support that colorspace. I print just warning.<br>
Currently we don't have that kind of paintop, so it should not be problem.<br>
<br>
Can I commit?<br>
</blockquote></div><br>Looks good.<br><br>I have two suggestions:<br>Can we use QStyledItemDelegate instead of QItemDelegate? That would give a more native look and less KDE 3 look.<br><br>Currently the paintops are sorted alphabetically. I think it would be better if in the stable category pixel brush is the first and then either smudge or duplicate.<br>