<div class="gmail_quote">On Sun, Sep 19, 2010 at 2:04 PM, Boudewijn Rempt <span dir="ltr"><<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div></div><div class="h5">On Sunday 19 September 2010, Sven Langkamp wrote:<br>
> On Sun, Sep 19, 2010 at 1:34 PM, Boudewijn Rempt <<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>> wrote:<br>
><br>
> > On Sunday 19 September 2010, Dmitry Kazakov wrote:<br>
> > > ><br>
> > > > The the KisNodeGraphListener is extended by a method to notify about<br>
> > node<br>
> > > > changes. Nodes call it when the systemLocked is turned off. I used<br>
> > > > systemLocked as it only called once an operation is finished, so we<br>
> > don't do<br>
> > > > updates that are not needed.<br>
> > > > The node model manages a queue for the nodes that will be updated after<br>
> > a<br>
> > > > one second timeout.<br>
> > > ><br>
> > > > Any comments?<br>
> > > ><br>
> > ><br>
> > > I have two comments about this:<br>
> > > 1) I don't think it is very good to use systemLocked call for this. I'm<br>
> > not<br>
> > > sure this ability (to lock the system) should live in future releases.<br>
> > It's<br>
> > > not good idea to block UI for any reason. So i temped to deprecate it in<br>
> > the<br>
> > > future.<br>
> ><br>
> > Well, systemLocked only locks the gui for a particular layer, so it's<br>
> > pretty safe. I don' think we'll lose that. But I still think that using<br>
> > KisImage::void sigImageUpdated should be enough to kick off the thumbnails<br>
> > timer.<br>
> ><br>
> ><br>
> sigImageUpdated doesn't contain information about the node that should be<br>
> updated. With sigNodeChanged only the node that was changed with regenerate<br>
> it's preview image.<br>
<br>
</div></div>Yes, that's right. One thing I might have missed is what happens when painting with the freehand tool -- that doesn't use systemlocked, does it?<br></blockquote><div><br>Yes, in some places we are still missing systemLocked. The layerbox can also be used to find them ;)<br>
For testing you can use the gradient tool. <br></div></div>