<div class="gmail_quote">On Mon, Jun 21, 2010 at 9:27 PM, Boudewijn Rempt <span dir="ltr"><<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On Sunday 20 June 2010, Sven Langkamp wrote:<br>
> Both classes share only a few methods that are common to both. At the same<br>
> time they have lots of stuff that is specific to one of them like updating<br>
> the projection in KisSelection or manipulation methods in pixel selection.<br>
> It would make more sense to put the methods that are the same in both<br>
> classes into a shared base class.<br>
<br>
</div>Hm... I'm not completely following the issues Dmitry has with the current<br>
design, but reflecting on the current code, I think it's a bit ugly that<br>
KisSelection _is_ the projection. How about something like:<br>
<br>
Make a KisSelection class that is not a paint device. Make it own:<br>
<br>
* KisPixelSelection::KisPaintdevice<br>
* KisVectorSelection<br>
* and a KisPaintDevice for the projection.<br>
<br>
similar to KisImage?<br>
<div><div></div><div class="h5"><br></div></div></blockquote><div><br>The way it's now is quite convenient. In most cases you just use the selection as mask without thinking about what's behind.<br>We need a projection anyway so where is the problem with KisSelection being the projection?<br>
<br>Changing this would also mean lots of work without much gain. </div></div>