Great work!<br><br>Can i make a couple of stylish comments? ;)<br><br>I think in KisMask::selection()<br> {<br> if (!m_d->selection) {<br>+ // FIXME: this violates the const<br> m_d->selection = new KisSelection();<br>
+ const KisLayer *parentLayer = qobject_cast<const KisLayer*>(parent());<br>+ m_d->selection->setDefaultBounds(KisDefaultBounds(parentLayer->image()));<br><br><br>you can shorten the code a bit:<br>
<br> if (!m_d->selection) {<br>
+ // FIXME: this violates the const<br>+
setSelection(new KisSelection());<br><br>I don't know whether it would compile due to const problem, just an idea...<br><br>And in selectedRect() functions i would use the & operator instead of intersected() function, just to be more brief. But this is a deal of taste... =)<br>
<br><br><br><div class="gmail_quote">On Sat, Mar 27, 2010 at 12:29 PM, Boudewijn Rempt <span dir="ltr"><<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On Saturday 27 March 2010, Sven Langkamp wrote:<br>
<br>
> The patch fixes the crash on inverting a global or local selection.<br>
<br>
</div>Cool work!<br>
<div><div></div><div class="h5">--<br>
Boudewijn Rempt | <a href="http://www.valdyas.org" target="_blank">http://www.valdyas.org</a><br>
_______________________________________________<br>
kimageshop mailing list<br>
<a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Dmitry Kazakov<br>