<br><br><div class="gmail_quote">On Tue, Jan 5, 2010 at 12:48 PM, Boudewijn Rempt <span dir="ltr"><<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5">On Tue, 5 Jan 2010, Dmitry Kazakov wrote:<br>
<br>
> On Tue, Jan 5, 2010 at 1:01 AM, Edward Apap <<a href="mailto:schumifer@hotmail.com">schumifer@hotmail.com</a>> wrote:<br>
><br>
> > SVN commit 1070110 by eapap:<br>
> ><br>
> > Use COMPOSITE_COPY when applying filter result<br>
> ><br>
> ><br>
> > M +1 -1 kis_filter_job.cpp<br>
> ><br>
> ><br>
> > --- trunk/koffice/krita/image/filter/kis_filter_job.cpp #1070109:1070110<br>
> > @@ -64,7 +64,7 @@<br>
> ><br>
> > // blt back onto the original<br>
> > KisPainter p2(m_dev);<br>
> > - p2.setCompositeOp(m_dev->colorSpace()->compositeOp(COMPOSITE_OVER));<br>
> > + p2.setCompositeOp(m_dev->colorSpace()->compositeOp(COMPOSITE_COPY));<br>
> > p2.setSelection(m_selection);<br>
> > p2.bitBlt(m_rc.topLeft(), dst, m_rc);<br>
> > p2.end();<br>
> ><br>
><br>
> COMPOSITE_COPY doesn't pay any attention to the selections. At least it used<br>
> to. Please check whether this patch breaks selected filter application.<br>
<br>
</div></div>Was there any reason for not fixing composite copy to take the mask into account?<br></blockquote></div><br>I don't know really. But it seems to me if we fix COMPOSITE_COPY, there will absolutely be no difference between COMPOSITE_COPY and COMPOSITE_OVER.<br>
<br>Just a thought: _COPY just copies area without any knowledge of it's content, while _OVER reads alpha() first.<br><br>-- <br>Dmitry Kazakov<br>