I'll commit a workaround tonight.<br><br>Just create a blur mask and paint on the layer with a brush with a diameter smaller than 2*width of a kernel.<br>The first applyMatrix will return an empty paintDevice, and the second applyMatrix will crash because of empty interm->extent().<br>
<br><br><div class="gmail_quote">On Sun, Dec 27, 2009 at 9:35 PM, Ed . <span dir="ltr"><<a href="mailto:schumifer@hotmail.com">schumifer@hotmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>
Could you elaborate what you are doing to crash Krita when painting on the mask?<br><br><hr>Date: Sun, 27 Dec 2009 14:08:02 +0300<div class="im"><br>Subject: Re: Consecutive Convolutions<br>From: <a href="mailto:dimula73@gmail.com" target="_blank">dimula73@gmail.com</a><br>
To: <a href="mailto:kimageshop@kde.org" target="_blank">kimageshop@kde.org</a><br><br></div><div><div></div><div class="h5">Well, i seem to have fixed this. Please update.<br><br>There are some crashes when you paint on the mask, i'm investigating this.<br>
<br><br>A couple of comments about the pacth:<br>1) There is no need to make a copy of a source device as convolution will do this for you one more time. I mean first line should be:<br>
KisPaintDeviceSP interm = new KisPaintDevice(src->colorSpace());<br><br>2) Shared pointers shouldn't be delete'ed. This may cause a crash =)<br><br clear="all">Final working version of the 'if':<br><br>
if ( (horizontalRadius > 0) && (verticalRadius > 0) )<br> {<br> KisPaintDeviceSP interm = new KisPaintDevice(src->colorSpace());<br><br> KisConvolutionKernelSP kernelHoriz = KisConvolutionKernel::fromMatrix(horizGaussian, 0, horizGaussian.sum());<br>
KisConvolutionKernelSP kernelVertical = KisConvolutionKernel::fromMatrix(verticalGaussian, 0, verticalGaussian.sum());<br><br> KisConvolutionPainter horizPainter(interm, dstInfo.selection());<br> horizPainter.applyMatrix(kernelHoriz, src, srcTopLeft, srcTopLeft, size, BORDER_REPEAT);<br>
<br> KisConvolutionPainter verticalPainter(dst, dstInfo.selection());<br> verticalPainter.applyMatrix(kernelVertical, interm, srcTopLeft, dstTopLeft, size, BORDER_REPEAT);<br><br> }<br><br><br>-- <br>Dmitry Kazakov<br>
<br></div></div><div class="hm"><hr>Windows Live Hotmail: <a href="http://www.microsoft.com/middleeast/windows/windowslive/see-it-in-action/social-network-basics.aspx?ocid=PID23461::T:WLMTAGL:ON:WL:en-xm:SI_SB_4:092009" target="_blank">Your friends can get your Facebook updates, right from Hotmail®.</a></div>
</div>
<br>_______________________________________________<br>
kimageshop mailing list<br>
<a href="mailto:kimageshop@kde.org">kimageshop@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kimageshop" target="_blank">https://mail.kde.org/mailman/listinfo/kimageshop</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Dmitry Kazakov<br>