<br><br><div class="gmail_quote">On Wed, Nov 4, 2009 at 9:49 PM, Boudewijn Rempt <span dir="ltr"><<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5">On Monday 02 November 2009, Dmitry Kazakov wrote:<br>
> I've fixed regressions of the patch. The third patch in a patchset is<br>
> attached.<br>
><br>
> Just a reminder, this patchset allows a user to choose a compositeOp for a<br>
> mask. A test-file is in my first mail.<br>
><br>
<br>
</div></div>Does this change give performance issues?<br>
<br>
- m_d->selection->getOrCreatePixelSelection()->select(parent()-<br>
>extent(), MAX_SELECTED);<br>
+ m_d->selection->getOrCreatePixelSelection()->select(parent()-<br>
>exactBounds(), MAX_SELECTED);<br>
<br>
For the rest, looks okay, and if you're sure this change doesn't cause<br>
problems, I'm fine with committing.<br></blockquote><div><br>It shouldn't cause anything as it is called only once during creation of the mask (of it's selection).<br>In theory, it is more right form the user's point of view. For example, i the first case, if he decides to move a mask with a moving tool, he'll see that borders of the mask are bigger than actual image and have bogus values. The second variant adds distinctness to this usecase.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
(As far as I am concernted, you can also swap KisBaseNode and KisNode, so the<br>
graph is the base and the properties the extension.)<br></blockquote><div>I'll try to do this. <br></div></div><br clear="all"><br>-- <br>Dmitry Kazakov<br>