<br><br><div class="gmail_quote">On Sun, Sep 27, 2009 at 2:20 PM, Boudewijn Rempt <span dir="ltr"><<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Sunday 27 September 2009, Boudewijn Rempt wrote:<br>
> Btw, if the unittests pass, please commit your patches. I think everyone<br>
> agrees on that now.<br>
><br>
<br>
</div>I've applied the patch now by hacking out the conflicts and the only test I<br>
see failing is KisPaintLayerTest on the transparency mask, which is fixed by<br>
not inverting the mask.<br></blockquote><div><br>What have you fixed? OPACITY_TRANSPARENT to OPACITY_OPAQUE? Right?<br> <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
About the other comments in the paint layer test:<br>
<br>
/**<br>
* FIXME: Needs approval by someone else<br>
* This is quite insane demands as a projection is still no way updated.<br>
* There is no difference for us whether layer->projection() is equal<br>
* to layer->paintDevice() or is equal to NULL, isn't it?<br>
*/<br>
// Which also means that the projection is no longer the paint device<br>
//QVERIFY(layer->paintDevice().data() != layer->projection().data());<br>
<br>
<br>
This is a check that as soon as we add masks, there is a projection. Not<br>
whether the projection has been updated or now. Now, if the projection is only<br>
created during the recomposition process in the new situation this test<br>
doesn't hold.<br></blockquote><div><br>Does it mean, that i can remove those lines?<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
You have to understand the basic nature of a unittest: it tests the expected<br>
behaviour of a class. If you change that behaviour, you have to change the<br>
test accordingly, but not just comment out tests. We have to be certain that<br>
this class is well behaved.<br></blockquote><div><br>=) As i understand tests' purpose is to fix "interface" of the classes :) And not to check it's internals =)<br> <br clear="all"></div></div><br>-- <br>
Dmitry Kazakov<br>