<div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div style="font-family: 'DejaVu Sans'; font-size: 9pt; font-weight: 400; font-style: normal;">
<div class="im">
> In such a case we miss loading of the default configuration from kritarc.<br>
> So return d->parentFilter->defaultConfiguration(); instead :P<br></div>
No we don't, since the factory is mainly used by the bookmark manager when reading from kritarc, and by using d->parentFilter->defaultConfiguration(); we create an infinite loop, since:<br>
defaultConfiguration() calls the bookmarkmanager which call the createDefault() from factory which calls defaultConfiguration() which calls the bookmarkmanager which call the createDefault() from factory which calls defaultConfiguration() which....<br>
<p style="margin: 0px; text-indent: 0px;"></p></div></blockquote><div><br>In such a case we should name it another way, because it doesn't load "real default configuration" (that is seen as default by the user).<br>
What about KisFilterConfigurationFactory::factoryConfiguration() ? <br>It just creates a new object, but not default config.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
</blockquote></div>Ok. Now i've updated my patch to the fourth version =) <br><a href="http://reviewboard.kde.org/r/203/">http://reviewboard.kde.org/r/203/</a><br>Hope, it'll be the last one (concerning this very bug). I've changed to/fromXML to be more like OpenRaster.<br>
<br>But i found some issues:<br>1a) KisPropertiesConfiguration doesn't conform to OpenRaster as it doesn't create something like <br><pre class="changedesc-text"><filter name="perchannel" type="applications:Krita:PerChannel">...</filter> </pre>
1b) It packs all the properties into CDATA structure. As i understood from specification properties should be written as simple text? Or this is the same?<br clear="all"><br><br>-- <br>Dmitry Kazakov<br>