New Defects reported by Coverity Scan for krita
scan-admin at coverity.com
scan-admin at coverity.com
Sat Jan 28 17:41:03 GMT 2023
Hi,
Please find the latest report on new defect(s) introduced to krita found with Coverity Scan.
297 new defect(s) introduced to krita found with Coverity Scan.
617 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 297 defect(s)
** CID 435434: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/ui/tool/strokes/move_stroke_strategy.cpp: 577 in Data(QPoint)()
________________________________________________________________________________________________________
*** CID 435434: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/ui/tool/strokes/move_stroke_strategy.cpp: 577 in Data(QPoint)()
571 }
572
573 MoveStrokeStrategy::Data::Data(QPoint _offset)
574 : KisStrokeJobData(SEQUENTIAL, NORMAL),
575 offset(_offset)
576 {
>>> CID 435434: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
577 }
578
579 KisStrokeJobData *MoveStrokeStrategy::Data::createLodClone(int levelOfDetail)
580 {
581 return new Data(*this, levelOfDetail);
582 }
** CID 435433: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/widgets/KisSpinboxHSXSelector.cpp: 47 in ~KisSpinboxHSXSelector()()
________________________________________________________________________________________________________
*** CID 435433: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/widgets/KisSpinboxHSXSelector.cpp: 47 in ~KisSpinboxHSXSelector()()
41 m_d->spinBoxes[1]->setSuffix(" %");
42 m_d->spinBoxes[2]->setSuffix(" %");
43 }
44
45 KisSpinboxHSXSelector::~KisSpinboxHSXSelector()
46 {
>>> CID 435433: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
47 }
48
49 void KisSpinboxHSXSelector::attachToSelector(KisVisualColorSelector *selector)
50 {
51 connect(selector, SIGNAL(sigColorModelChanged()), this, SLOT(slotColorModelChanged()));
52 connect(selector, SIGNAL(sigHSXChanged(QVector3D)), this, SLOT(slotHSXChanged(QVector3D)));
** CID 435432: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/resources/KoLocalStrokeCanvasResources.cpp: 36 in ~KoLocalStrokeCanvasResources()()
________________________________________________________________________________________________________
*** CID 435432: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/resources/KoLocalStrokeCanvasResources.cpp: 36 in ~KoLocalStrokeCanvasResources()()
30 m_d->resources = rhs.m_d->resources;
31 return *this;
32 }
33
34 KoLocalStrokeCanvasResources::~KoLocalStrokeCanvasResources()
35 {
>>> CID 435432: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
36 }
37
38
39 QVariant KoLocalStrokeCanvasResources::resource(int key) const
40 {
41 return m_d->resources.value(key, QVariant());
** CID 435431: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/image/brushengine/kis_random_source.cpp: 35 in KisRandomSource()()
________________________________________________________________________________________________________
*** CID 435431: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/image/brushengine/kis_random_source.cpp: 35 in KisRandomSource()()
29 };
30
31
32 KisRandomSource::KisRandomSource()
33 : m_d(new Private)
34 {
>>> CID 435431: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
35 }
36
37 KisRandomSource::KisRandomSource(int seed)
38 : m_d(new Private(seed))
39 {
40 }
** CID 435430: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/plugins/dockers/animation/KisAnimCurvesValuesHeader.cpp: 46 in ~KisAnimCurvesValuesHeader()()
________________________________________________________________________________________________________
*** CID 435430: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/plugins/dockers/animation/KisAnimCurvesValuesHeader.cpp: 46 in ~KisAnimCurvesValuesHeader()()
40 {
41 m_d->modifiersCatcher.reset(new KisCustomModifiersCatcher(parent));
42 m_d->modifiersCatcher->addModifier("pan-zoom", Qt::Key_Space);
43 }
44
45 KisAnimCurvesValuesHeader::~KisAnimCurvesValuesHeader()
>>> CID 435430: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
46 {}
47
48 void KisAnimCurvesValuesHeader::setScale(qreal scale)
49 {
50 const qreal minimumScale = 0.001f;
51 m_d->scale = qMax(scale, minimumScale);
** CID 435429: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/flake/KoVectorPatternBackground.cpp: 46 in ~KoVectorPatternBackground()()
________________________________________________________________________________________________________
*** CID 435429: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/flake/KoVectorPatternBackground.cpp: 46 in ~KoVectorPatternBackground()()
40 {
41 }
42
43 KoVectorPatternBackground::~KoVectorPatternBackground()
44 {
45
>>> CID 435429: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
46 }
47
48 bool KoVectorPatternBackground::compareTo(const KoShapeBackground *other) const
49 {
50 Q_UNUSED(other);
51 return false;
** CID 435428: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/flake/text/KoSvgTextProperties.cpp: 33 in ~KoSvgTextProperties()()
________________________________________________________________________________________________________
*** CID 435428: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/flake/text/KoSvgTextProperties.cpp: 33 in ~KoSvgTextProperties()()
27 : m_d(new Private)
28 {
29 }
30
31 KoSvgTextProperties::~KoSvgTextProperties()
32 {
>>> CID 435428: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
33 }
34
35 KoSvgTextProperties::KoSvgTextProperties(const KoSvgTextProperties &rhs)
36 : m_d(new Private)
37 {
38 m_d->properties = rhs.m_d->properties;
** CID 435427: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/flake/KoDerivedResourceConverter.cpp: 32 in ~KoDerivedResourceConverter()()
________________________________________________________________________________________________________
*** CID 435427: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/flake/KoDerivedResourceConverter.cpp: 32 in ~KoDerivedResourceConverter()()
26 : m_d(new Private(key, sourceKey))
27 {
28 }
29
30 KoDerivedResourceConverter::~KoDerivedResourceConverter()
31 {
>>> CID 435427: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
32 }
33
34 int KoDerivedResourceConverter::key() const
35 {
36 return m_d->key;
37 }
** CID 435426: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/flake/KoHatchBackground.cpp: 48 in ~KoHatchBackground()()
________________________________________________________________________________________________________
*** CID 435426: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/flake/KoHatchBackground.cpp: 48 in ~KoHatchBackground()()
42 , d(new Private)
43 {
44 }
45
46 KoHatchBackground::~KoHatchBackground()
47 {
>>> CID 435426: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
48 }
49
50 void KoHatchBackground::paint(QPainter &painter, const QPainterPath &fillPath) const
51 {
52 if (color().isValid()) {
53 // paint background color if set by using the color background
** CID 435425: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/widgetutils/KoProperties.cpp: 22 in KoProperties()()
________________________________________________________________________________________________________
*** CID 435425: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/widgetutils/KoProperties.cpp: 22 in KoProperties()()
16 QMap<QString, QVariant> properties;
17 };
18
19 KoProperties::KoProperties()
20 : d(new Private())
21 {
>>> CID 435425: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
22 }
23
24 KoProperties::KoProperties(const KoProperties & rhs)
25 : d(new Private())
26 {
27 d->properties = rhs.d->properties;
** CID 435424: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/ui/canvas/KisMirrorAxisConfig.cpp: 62 in KisMirrorAxisConfig()()
________________________________________________________________________________________________________
*** CID 435424: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/ui/canvas/KisMirrorAxisConfig.cpp: 62 in KisMirrorAxisConfig()()
56
57 KisMirrorAxisConfig::KisMirrorAxisConfig()
58 : QObject()
59 , d(new Private())
60 {
61
>>> CID 435424: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
62 }
63
64 KisMirrorAxisConfig::~KisMirrorAxisConfig()
65 {
66
67 }
** CID 435423: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/widgetutils/KisOptionButtonStrip.cpp: 47 in ~KisOptionButtonStrip()()
________________________________________________________________________________________________________
*** CID 435423: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/widgetutils/KisOptionButtonStrip.cpp: 47 in ~KisOptionButtonStrip()()
41 emit buttonToggled(m_d->buttonGroup->id(button), checked);
42 });
43 }
44
45 KisOptionButtonStrip::~KisOptionButtonStrip()
46 {
>>> CID 435423: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
47 }
48
49 KoGroupButton *KisOptionButtonStrip::addButton(const QIcon &icon,
50 const QString &text)
51 {
52 KoGroupButton *newButton = new KoGroupButton(this);
** CID 435422: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/plugins/dockers/animation/kis_custom_modifiers_catcher.cpp: 45 in ~KisCustomModifiersCatcher()()
________________________________________________________________________________________________________
*** CID 435422: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/plugins/dockers/animation/kis_custom_modifiers_catcher.cpp: 45 in ~KisCustomModifiersCatcher()()
39 parent->installEventFilter(this);
40 }
41 }
42
43 KisCustomModifiersCatcher::~KisCustomModifiersCatcher()
44 {
>>> CID 435422: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
45 }
46
47 void KisCustomModifiersCatcher::addModifier(const QString &id, Qt::Key modifier)
48 {
49 m_d->idToKeyMap.insert(id, modifier);
50 m_d->trackedKeys.insert(modifier);
** CID 435421: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/resources/KisStorageFilterProxyModel.cpp: 25 in KisStorageFilterProxyModel(QObject *)()
________________________________________________________________________________________________________
*** CID 435421: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/resources/KisStorageFilterProxyModel.cpp: 25 in KisStorageFilterProxyModel(QObject *)()
19 };
20
21 KisStorageFilterProxyModel::KisStorageFilterProxyModel(QObject *parent)
22 : QSortFilterProxyModel(parent)
23 , d(new Private)
24 {
>>> CID 435421: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
25 }
26
27 KisStorageFilterProxyModel::~KisStorageFilterProxyModel()
28 {
29 delete d;
30 }
** CID 435420: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/plugins/color/lcms2engine/colorprofiles/IccColorProfile.cpp: 32 in Data()()
________________________________________________________________________________________________________
*** CID 435420: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/plugins/color/lcms2engine/colorprofiles/IccColorProfile.cpp: 32 in Data()()
26 QByteArray rawData;
27 };
28
29 IccColorProfile::Data::Data()
30 : d(new Private)
31 {
>>> CID 435420: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
32 }
33 IccColorProfile::Data::Data(const QByteArray &rawData)
34 : d(new Private)
35 {
36 d->rawData = rawData;
37 }
** CID 435419: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/ui/kis_file_layer.cpp: 70 in ~KisFileLayer()()
________________________________________________________________________________________________________
*** CID 435419: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/ui/kis_file_layer.cpp: 70 in ~KisFileLayer()()
64 m_loader.reloadImage();
65 }
66 }
67
68 KisFileLayer::~KisFileLayer()
69 {
>>> CID 435419: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
70 }
71
72 KisFileLayer::KisFileLayer(const KisFileLayer &rhs)
73 : KisExternalLayer(rhs)
74 {
75 m_basePath = rhs.m_basePath;
** CID 435418: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/flake/text/KoSvgTextChunkShape.cpp: 900 in ~SharedData()()
________________________________________________________________________________________________________
*** CID 435418: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/flake/text/KoSvgTextChunkShape.cpp: 900 in ~SharedData()()
894 , isRichTextPreferred(rhs.isRichTextPreferred)
895 {
896 }
897
898 KoSvgTextChunkShape::SharedData::~SharedData()
899 {
>>> CID 435418: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
900 }
901
902 #include <QBrush>
903 #include <KoColorBackground.h>
904 #include <KoShapeStroke.h>
905
** CID 435417: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/koplugin/KoJsonTrader.cpp: 123 in ~KoJsonTrader()()
________________________________________________________________________________________________________
*** CID 435417: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/koplugin/KoJsonTrader.cpp: 123 in ~KoJsonTrader()()
117
118 initializePluginLoaderCache();
119 }
120
121 KoJsonTrader::~KoJsonTrader()
122 {
>>> CID 435417: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
123 }
124
125
126 Q_GLOBAL_STATIC(KoJsonTrader, s_instance)
127
128 KoJsonTrader* KoJsonTrader::instance()
** CID 435416: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/ui/input/config/kis_input_mode_delegate.cpp: 25 in KisInputModeDelegate(QObject *)()
________________________________________________________________________________________________________
*** CID 435416: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/ui/input/config/kis_input_mode_delegate.cpp: 25 in KisInputModeDelegate(QObject *)()
19 KisAbstractInputAction *action {nullptr};
20 };
21
22 KisInputModeDelegate::KisInputModeDelegate(QObject *parent)
23 : QStyledItemDelegate(parent), d(new Private)
24 {
>>> CID 435416: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
25 }
26
27 KisInputModeDelegate::~KisInputModeDelegate()
28 {
29 delete d;
30
** CID 435415: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/widgetutils/KisActionsSnapshot.cpp: 44 in ~KisActionsSnapshot()()
________________________________________________________________________________________________________
*** CID 435415: Uninitialized variables (MISSING_RETURN)
/home/tymon/kritadev/krita/libs/widgetutils/KisActionsSnapshot.cpp: 44 in ~KisActionsSnapshot()()
38 #endif
39
40 }
41
42 KisActionsSnapshot::~KisActionsSnapshot()
43 {
>>> CID 435415: Uninitialized variables (MISSING_RETURN)
>>> Arriving at the end of a function without returning a value.
44 }
45
46 void KisActionsSnapshot::addAction(const QString &name, QAction *action)
47 {
48 m_d->nonRegisteredShortcuts.remove(name);
49 KisActionRegistry::ActionCategory cat = KisActionRegistry::instance()->fetchActionCategory(name);
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoiVvSSc0Ywjss83d7yOEUgcCB0VGS755ZaA-2FhoVtwbuw-3D-3DWF6r_9IaX5f-2FHpKL9E6YDsrt7GXrayr4Tk6CKCUhJvkNHrt7rOKjrEnqXFeHqmrknDjlUV-2FCVg6d3c4IHPYgKx2S1Jtwe99eKaV6QaHcfFE8JiMdNLEJXfNsMnKlUNvQt8V-2FvRURkNccxUN5jnL6vqUfvb67eSvZ6pjQ3QPRlYYWSB8WIDNxbnw6KJU8V2WKc7-2Fc8N5u57kLXJODZV8h3C-2BTfQA-3D-3D
More information about the kimageshop
mailing list