New Defects reported by Coverity Scan for krita
scan-admin at coverity.com
scan-admin at coverity.com
Tue Jul 14 18:29:22 BST 2020
Hi,
Please find the latest report on new defect(s) introduced to krita found with Coverity Scan.
101 new defect(s) introduced to krita found with Coverity Scan.
105 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 101 defect(s)
** CID 305054: Incorrect expression (UNINTENDED_INTEGER_DIVISION)
/home/boud/dev/krita/plugins/tools/selectiontools/KisMagneticWorker.cc: 138 in WeightMap::operator [](const std::pair<VertexDescriptor, VertexDescriptor> &)()
________________________________________________________________________________________________________
*** CID 305054: Incorrect expression (UNINTENDED_INTEGER_DIVISION)
/home/boud/dev/krita/plugins/tools/selectiontools/KisMagneticWorker.cc: 138 in WeightMap::operator [](const std::pair<VertexDescriptor, VertexDescriptor> &)()
132 m_graph(g)
133 { }
134
135 data_type &operator [] (key_type const &k)
136 {
137 if (m_map.find(k) == m_map.end()) {
>>> CID 305054: Incorrect expression (UNINTENDED_INTEGER_DIVISION)
>>> Dividing integer expressions "this->m_graph.getIntensity(k.first) + this->m_graph.getIntensity(k.second)" and "2", and then converting the integer quotient to type "double". Any remainder, or fractional part of the quotient, is ignored.
138 double edge_gradient = (m_graph.getIntensity(k.first) + m_graph.getIntensity(k.second)) / 2;
139 m_map[k] = EuclideanDistance(k.first, k.second) + 255.0 - edge_gradient;
140 }
141 return m_map[k];
142 }
143
** CID 305053: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/libs/widgets/KisPaletteChooser.cpp: 143 in KisPaletteChooserPrivate::KisPaletteChooserPrivate(KisPaletteChooser *)()
________________________________________________________________________________________________________
*** CID 305053: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/libs/widgets/KisPaletteChooser.cpp: 143 in KisPaletteChooserPrivate::KisPaletteChooserPrivate(KisPaletteChooser *)()
137 /************************* KisPaletteChooserPrivate **********************/
138
139 KisPaletteChooserPrivate::KisPaletteChooserPrivate(KisPaletteChooser *a_c)
140 : c(a_c)
141 , itemChooser(new KisResourceItemChooser(ResourceType::Palettes, false, a_c))
142 , delegate(new Delegate(a_c))
>>> CID 305053: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "allowModification" is not initialized in this constructor nor in any functions that it calls.
143 { }
144
145 KisPaletteChooserPrivate::~KisPaletteChooserPrivate()
146 { }
147
148 /******************* KisPaletteChooserPrivate::Delegate ******************/
** CID 304993: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 304993: Null pointer dereferences (FORWARD_NULL)
/home/boud/dev/krita/plugins/paintops/libpaintop/kis_auto_brush_widget.cpp: 246 in KisAutoBrushWidget::setBrush(QSharedPointer<KisBrush>)()
240 KisAutoBrush* aBrush = dynamic_cast<KisAutoBrush*>(brush.data());
241
242 KisSignalsBlocker b1(comboBoxShape, comboBoxMaskType);
243 KisSignalsBlocker b2(inputRadius, inputRatio, inputHFade, inputVFade, inputAngle, inputSpikes);
244 KisSignalsBlocker b3(spacingWidget, inputRandomness, density, softnessCurve, btnAntialiasing);
245
>>> CID 304993: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "aBrush" to "maskGenerator", which dereferences it.
246 if (aBrush->maskGenerator()->type() == KisMaskGenerator::CIRCLE) {
247 comboBoxShape->setCurrentIndex(0);
248 }
249 else if (aBrush->maskGenerator()->type() == KisMaskGenerator::RECTANGLE) {
250 comboBoxShape->setCurrentIndex(1);
251 }
** CID 304992: Incorrect expression (USELESS_CALL)
________________________________________________________________________________________________________
*** CID 304992: Incorrect expression (USELESS_CALL)
/usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h: 931 in QVector<QPoint>::erase(QTypedArrayData<QPoint>::iterator, QTypedArrayData<QPoint>::iterator)()
925 aend = abegin + itemsToErase;
926 if (!QTypeInfoQuery<T>::isRelocatable) {
927 iterator moveBegin = abegin + itemsToErase;
928 iterator moveEnd = d->end();
929 while (moveBegin != moveEnd) {
930 if (QTypeInfo<T>::isComplex)
>>> CID 304992: Incorrect expression (USELESS_CALL)
>>> Calling "abegin.operator QPoint *()" is only useful for its return value, which is ignored.
931 static_cast<T *>(abegin)->~T();
932 new (abegin++) T(*moveBegin++);
933 }
934 if (abegin < d->end()) {
935 // destroy rest of instances
936 destruct(abegin, d->end());
** CID 304991: Control flow issues (UNREACHABLE)
/home/boud/dev/krita/plugins/impex/kra/kra_converter.cpp: 423 in KraConverter::completeLoading(KoStore *)()
________________________________________________________________________________________________________
*** CID 304991: Control flow issues (UNREACHABLE)
/home/boud/dev/krita/plugins/impex/kra/kra_converter.cpp: 423 in KraConverter::completeLoading(KoStore *)()
417 }
418
419 m_activeNodes = m_kraLoader->selectedNodes();
420 m_assistants = m_kraLoader->assistants();
421
422 return true;
>>> CID 304991: Control flow issues (UNREACHABLE)
>>> This code cannot be reached: "return QStringList(this->m_...".
423 return m_kraLoader->errorMessages().isEmpty();
424 }
425
426 void KraConverter::cancel()
427 {
428 m_stop = true;
** CID 304990: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/plugins/paintops/hatching/kis_hatching_paintop_settings.cpp: 40 in KisHatchingPaintOpSettings::KisHatchingPaintOpSettings(QSharedPointer<KisResourcesInterface>)()
________________________________________________________________________________________________________
*** CID 304990: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/plugins/paintops/hatching/kis_hatching_paintop_settings.cpp: 40 in KisHatchingPaintOpSettings::KisHatchingPaintOpSettings(QSharedPointer<KisResourcesInterface>)()
34
35 KisHatchingPaintOpSettings::KisHatchingPaintOpSettings(KisResourcesInterfaceSP resourcesInterface)
36 : KisBrushBasedPaintOpSettings(resourcesInterface),
37 m_d(new Private)
38 {
39 setProperty(HATCHING_VERSION, "2");
>>> CID 304990: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "thicknesssensorvalue" is not initialized in this constructor nor in any functions that it calls.
40 }
41
42 KisHatchingPaintOpSettings::~KisHatchingPaintOpSettings()
43 {
44 }
45
** CID 304989: Error handling issues (CHECKED_RETURN)
/home/boud/dev/krita/libs/resources/KisResourceModel.cpp: 564 in KisResourceModel::rowCount(const QModelIndex &) const()
________________________________________________________________________________________________________
*** CID 304989: Error handling issues (CHECKED_RETURN)
/home/boud/dev/krita/libs/resources/KisResourceModel.cpp: 564 in KisResourceModel::rowCount(const QModelIndex &) const()
558 "WHERE resources.resource_type_id = resource_types.id\n"
559 "AND resource_types.name = :resource_type\n"
560 "AND resources.storage_id = storages.id\n"
561 "AND resources.status = 1\n"
562 "AND storages.active = 1");
563 q.bindValue(":resource_type", d->resourceType);
>>> CID 304989: Error handling issues (CHECKED_RETURN)
>>> Calling "exec" without checking return value (as is done elsewhere 63 out of 67 times).
564 q.exec();
565 q.first();
566
567 const_cast<KisResourceModel*>(this)->d->cachedRowCount = q.value(0).toInt();
568 }
569
570 return d->cachedRowCount;
** CID 304988: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/libs/image/kis_gradient_painter.cc: 619 in <unnamed>::RepeatForwardsPaintPolicy::RepeatForwardsPaintPolicy(KisGradientPainter::enumGradientShape)()
________________________________________________________________________________________________________
*** CID 304988: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/libs/image/kis_gradient_painter.cc: 619 in <unnamed>::RepeatForwardsPaintPolicy::RepeatForwardsPaintPolicy(KisGradientPainter::enumGradientShape)()
613 const KoColorSpace *m_colorSpace;
614 mutable QVector<quint8> m_resultColor;
615 };
616
617 RepeatForwardsPaintPolicy::RepeatForwardsPaintPolicy(KisGradientPainter::enumGradientShape shape)
618 : m_shape(shape)
>>> CID 304988: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_colorSpace" is not initialized in this constructor nor in any functions that it calls.
619 {}
620
621 void RepeatForwardsPaintPolicy::setup(const QPointF& gradientVectorStart,
622 const QPointF& gradientVectorEnd,
623 const QSharedPointer<KisGradientShapeStrategy> &shapeStrategy,
624 const GradientRepeatStrategy *repeatStrategy,
** CID 304987: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/plugins/dockers/svgcollectiondocker/SvgSymbolCollectionDocker.cpp: 229 in SvgSymbolCollectionDocker::SvgSymbolCollectionDocker(QWidget *)()
________________________________________________________________________________________________________
*** CID 304987: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/plugins/dockers/svgcollectiondocker/SvgSymbolCollectionDocker.cpp: 229 in SvgSymbolCollectionDocker::SvgSymbolCollectionDocker(QWidget *)()
223 }
224 m_wdgSvgCollection->cmbCollections->setCurrentIndex(i);
225 collectionActivated(i);
226
227 connect(m_resourceModel, SIGNAL(modelAboutToBeReset()), this, SLOT(slotResourceModelAboutToBeReset()));
228 connect(m_resourceModel, SIGNAL(modelReset()), this, SLOT(slotResourceModelReset()));
>>> CID 304987: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_rememberedSvgCollectionId" is not initialized in this constructor nor in any functions that it calls.
229 }
230
231 SvgSymbolCollectionDocker::~SvgSymbolCollectionDocker()
232 {
233 clearModels();
234 }
** CID 304986: Null pointer dereferences (FORWARD_NULL)
/home/boud/dev/krita/libs/libqml/plugins/kritasketchplugin/models/FiltersCategoryModel.cpp: 231 in FiltersCategoryModel::filterConfigurationChanged(int, FiltersModel *)()
________________________________________________________________________________________________________
*** CID 304986: Null pointer dereferences (FORWARD_NULL)
/home/boud/dev/krita/libs/libqml/plugins/kritasketchplugin/models/FiltersCategoryModel.cpp: 231 in FiltersCategoryModel::filterConfigurationChanged(int, FiltersModel *)()
225 }
226 KisFilterConfigurationSP config;
227 KisFilter* filter = model->filter(index);
228 if (filter->showConfigurationWidget() && filter->id() != QLatin1String("colortransfer")) {
229 KisConfigWidget* wdg = filter->createConfigurationWidget(0, d->view->activeNode()->original(), false);
230 wdg->deleteLater();
>>> CID 304986: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "dynamic_cast <KisFilterConfiguration *>(KisPropertiesConfigurationSP(wdg->configuration()).data())" to "clone", which dereferences it. (The dereference happens because this is a virtual function call.)
231 config = dynamic_cast<KisFilterConfiguration*>(wdg->configuration().data())->clone();
232 }
233 else {
234 config = filter->defaultConfiguration(KisGlobalResourcesInterface::instance())->clone();
235 }
236 QObject* configuration = d->categories[d->currentCategory]->configuration(index);
** CID 304985: (FORWARD_NULL)
/home/boud/dev/krita/libs/image/processing/kis_convert_color_space_processing_visitor.cpp: 78 in KisConvertColorSpaceProcessingVisitor::visitNodeWithPaintDevice(KisNode *, KisUndoAdapter *)()
/home/boud/dev/krita/libs/image/processing/kis_convert_color_space_processing_visitor.cpp: 101 in KisConvertColorSpaceProcessingVisitor::visitNodeWithPaintDevice(KisNode *, KisUndoAdapter *)()
________________________________________________________________________________________________________
*** CID 304985: (FORWARD_NULL)
/home/boud/dev/krita/libs/image/processing/kis_convert_color_space_processing_visitor.cpp: 78 in KisConvertColorSpaceProcessingVisitor::visitNodeWithPaintDevice(KisNode *, KisUndoAdapter *)()
72 alphaLock = paintLayer->alphaLocked();
73 new KisChangeChannelLockFlagsCommand(QBitArray(), paintLayer, parentConversionCommand);
74 }
75 }
76
77
>>> CID 304985: (FORWARD_NULL)
>>> Passing null pointer "layer" to "original", which dereferences it. (The dereference happens because this is a virtual function call.)
78 if (layer->original()) {
79 layer->original()->convertTo(m_dstColorSpace, m_renderingIntent, m_conversionFlags, parentConversionCommand);
80 }
81
82 if (layer->paintDevice()) {
83 layer->paintDevice()->convertTo(m_dstColorSpace, m_renderingIntent, m_conversionFlags, parentConversionCommand);
/home/boud/dev/krita/libs/image/processing/kis_convert_color_space_processing_visitor.cpp: 69 in KisConvertColorSpaceProcessingVisitor::visitNodeWithPaintDevice(KisNode *, KisUndoAdapter *)()
63
64 KisPaintLayer *paintLayer = 0;
65
66 KUndo2Command *parentConversionCommand = new KUndo2Command();
67
68 if (m_srcColorSpace->colorModelId() != m_dstColorSpace->colorModelId()) {
>>> CID 304985: (FORWARD_NULL)
>>> Passing null pointer "layer" to "alphaChannelDisabled", which dereferences it.
69 alphaDisabled = layer->alphaChannelDisabled();
70 new KisChangeChannelFlagsCommand(QBitArray(), layer, parentConversionCommand);
71 if ((paintLayer = dynamic_cast<KisPaintLayer*>(layer))) {
72 alphaLock = paintLayer->alphaLocked();
73 new KisChangeChannelLockFlagsCommand(QBitArray(), paintLayer, parentConversionCommand);
74 }
/home/boud/dev/krita/libs/image/processing/kis_convert_color_space_processing_visitor.cpp: 101 in KisConvertColorSpaceProcessingVisitor::visitNodeWithPaintDevice(KisNode *, KisUndoAdapter *)()
95 if (paintLayer && alphaLock) {
96 new KisChangeChannelLockFlagsCommand(m_dstColorSpace->channelFlags(true, false),
97 paintLayer, parentConversionCommand);
98 }
99
100 undoAdapter->addCommand(parentConversionCommand);
>>> CID 304985: (FORWARD_NULL)
>>> Passing null pointer "layer" to "extent", which dereferences it. (The dereference happens because this is a virtual function call.)
101 layer->invalidateFrames(KisTimeRange::infinite(0), layer->extent());
102 }
103
104 void KisConvertColorSpaceProcessingVisitor::visit(KisTransformMask *node, KisUndoAdapter *undoAdapter)
105 {
106 node->threadSafeForceStaticImageUpdate();
** CID 304984: Resource leaks (VIRTUAL_DTOR)
/home/boud/dev/krita/libs/resources/KisResourcesInterface_p.h: 47 in ()
________________________________________________________________________________________________________
*** CID 304984: Resource leaks (VIRTUAL_DTOR)
/home/boud/dev/krita/libs/resources/KisResourcesInterface_p.h: 47 in ()
41 return qHash(s);
42 }
43 };
44 }
45 #endif
46
>>> CID 304984: Resource leaks (VIRTUAL_DTOR)
>>> Class "KisResourcesInterfacePrivate" does not have a virtual destructor.
47 class KRITARESOURCES_EXPORT KisResourcesInterfacePrivate
48 {
49 public:
50 mutable std::unordered_map<QString,
51 std::unique_ptr<
52 KisResourcesInterface::ResourceSourceAdapter>> sourceAdapters;
** CID 304983: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 304983: Null pointer dereferences (FORWARD_NULL)
/home/boud/dev/krita/libs/ui/KisMainWindow.cpp: 1188 in KisMainWindow::layoutThumbnail()()
1182 gc.fillRect(0, 0, layoutThumbnail.width(), layoutThumbnail.height(), this->palette().dark());
1183
1184 for (int childW = 0; childW< children().size(); childW++) {
1185 if (children().at(childW)->isWidgetType()) {
1186 QWidget *w = dynamic_cast<QWidget*>(children().at(childW));
1187
>>> CID 304983: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "w" to "isVisible", which dereferences it.
1188 if (w->isVisible()) {
1189 QRect wRect = QRectF(w->geometry().x()*scale
1190 , w->geometry().y()*scale
1191 , w->geometry().width()*scale
1192 , w->geometry().height()*scale
1193 ).toRect();
** CID 304982: Error handling issues (CHECKED_RETURN)
/home/boud/dev/krita/libs/resources/KisResourceTypeModel.cpp: 46 in KisResourceTypeModel::rowCount(const QModelIndex &) const()
________________________________________________________________________________________________________
*** CID 304982: Error handling issues (CHECKED_RETURN)
/home/boud/dev/krita/libs/resources/KisResourceTypeModel.cpp: 46 in KisResourceTypeModel::rowCount(const QModelIndex &) const()
40 }
41
42 int KisResourceTypeModel::rowCount(const QModelIndex &/*parent*/) const
43 {
44 if (d->cachedRowCount < 0) {
45 QSqlQuery q;
>>> CID 304982: Error handling issues (CHECKED_RETURN)
>>> Calling "prepare" without checking return value (as is done elsewhere 58 out of 64 times).
46 q.prepare("SELECT count(*)\n"
47 "FROM resource_types\n");
48 q.exec();
49 q.first();
50
51 const_cast<KisResourceTypeModel*>(this)->d->cachedRowCount = q.value(0).toInt();
** CID 304981: Error handling issues (CHECKED_RETURN)
/home/boud/dev/krita/libs/resources/tests/TestResourceLocator.cpp: 74 in TestResourceLocator::testLocatorInitialization()()
________________________________________________________________________________________________________
*** CID 304981: Error handling issues (CHECKED_RETURN)
/home/boud/dev/krita/libs/resources/tests/TestResourceLocator.cpp: 74 in TestResourceLocator::testLocatorInitialization()()
68
69 ResourceTestHelper::createDummyLoaderRegistry();
70 }
71
72 void TestResourceLocator::testLocatorInitialization()
73 {
>>> CID 304981: Error handling issues (CHECKED_RETURN)
>>> Calling "initialize" without checking return value (as is done elsewhere 8 out of 10 times).
74 KisResourceCacheDb::initialize(QStandardPaths::writableLocation(QStandardPaths::AppDataLocation));
75 KisResourceLocator::LocatorError r = m_locator->initialize(m_srcLocation);
76 if (!m_locator->errorMessages().isEmpty()) qDebug() << m_locator->errorMessages();
77 QVERIFY(r == KisResourceLocator::LocatorError::Ok);
78 QVERIFY(QDir(m_dstLocation).exists());
79 Q_FOREACH(const QString &folder, KisResourceLoaderRegistry::instance()->resourceTypes()) {
** CID 304980: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/libs/ui/dialogs/kis_dlg_layer_style.cpp: 491 in StylesSelector::LocationProxyModel::LocationProxyModel(QObject *)()
________________________________________________________________________________________________________
*** CID 304980: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/libs/ui/dialogs/kis_dlg_layer_style.cpp: 491 in StylesSelector::LocationProxyModel::LocationProxyModel(QObject *)()
485 /********************************************************************/
486
487 StylesSelector::LocationProxyModel::LocationProxyModel(QObject *parent)
488 : QSortFilterProxyModel(parent)
489 {
490
>>> CID 304980: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_enableFiltering" is not initialized in this constructor nor in any functions that it calls.
491 }
492
493 void StylesSelector::LocationProxyModel::setEnableFiltering(bool enableFiltering)
494 {
495 m_enableFiltering = enableFiltering;
496 invalidateFilter();
** CID 304979: Memory - corruptions (OVERRUN)
/home/boud/dev/krita/libs/brush/tests/TestAbrStorage.cpp: 78 in TestAbrStorage::testResourceItem()()
________________________________________________________________________________________________________
*** CID 304979: Memory - corruptions (OVERRUN)
/home/boud/dev/krita/libs/brush/tests/TestAbrStorage.cpp: 78 in TestAbrStorage::testResourceItem()()
72
73 void TestAbrStorage::testResourceItem()
74 {
75 QString name = "brushes_by_mar_ka_d338ela";
76 QString filename = name + ".abr";
77 QString resourceName = name + "_2"; // "1" seem to be invalid or something; it isn't not loaded in any case.
>>> CID 304979: Memory - corruptions (OVERRUN)
>>> ""/home/boud/dev/krita/libs/brush/tests/data/" + '/'" evaluates to an address that is at byte offset 47 of an array of 44 bytes.
78 KisAbrStorage storage(FILES_DATA_DIR + '/' + filename);
79
80 KisResourceStorage::ResourceItem item = storage.resourceItem(resourceName);
81 QVERIFY(!item.url.isEmpty());
82 }
83
** CID 304978: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/libs/image/floodfill/kis_scanline_fill.cpp: 239 in SelectednessPolicyOptimized::SelectednessPolicyOptimized()()
________________________________________________________________________________________________________
*** CID 304978: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/libs/image/floodfill/kis_scanline_fill.cpp: 239 in SelectednessPolicyOptimized::SelectednessPolicyOptimized()()
233 }
234
235 private:
236 HashType m_selectedness;
237
238 const KoColorSpace *m_colorSpace;
>>> CID 304978: Uninitialized members (UNINIT_CTOR)
>>> The compiler-generated constructor for this class does not initialize "m_threshold".
239 int m_threshold;
240 };
241
242
243 template <bool useSmoothSelection,
244 class DifferencePolicy,
** CID 304977: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/plugins/tools/selectiontools/KisMagneticGraph.h: 198 in neighbour_iterator::neighbour_iterator()()
________________________________________________________________________________________________________
*** CID 304977: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/plugins/tools/selectiontools/KisMagneticGraph.h: 198 in neighbour_iterator::neighbour_iterator()()
192 , std::pair<VertexDescriptor, VertexDescriptor> > {
193 neighbour_iterator(VertexDescriptor v, KisMagneticGraph g, VertexDescriptor::Direction d) :
194 m_point(v), m_direction(d), m_graph(g)
195 { }
196
197 neighbour_iterator()
>>> CID 304977: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_direction" is not initialized in this constructor nor in any functions that it calls.
198 { }
199
200 std::pair<VertexDescriptor, VertexDescriptor> operator * () const
201 {
202 std::pair<VertexDescriptor,
203 VertexDescriptor> const result = std::make_pair(m_point, m_point.neighbor(m_direction));
** CID 304976: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/libs/resources/tests/TestStorageModel.h: 38 in TestStorageModel::TestStorageModel()()
________________________________________________________________________________________________________
*** CID 304976: Uninitialized members (UNINIT_CTOR)
/home/boud/dev/krita/libs/resources/tests/TestStorageModel.h: 38 in TestStorageModel::TestStorageModel()()
32 void testMetaData();
33
34 private:
35
36 QString m_srcLocation;
37 QString m_dstLocation;
>>> CID 304976: Uninitialized members (UNINIT_CTOR)
>>> The compiler-generated constructor for this class does not initialize "m_locator".
38 KisResourceLocator *m_locator;
39 };
40
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoiVvSSc0Ywjss83d7yOEUgcCB0VGS755ZaA-2FhoVtwbuw-3D-3DMQIg_9IaX5f-2FHpKL9E6YDsrt7GXrayr4Tk6CKCUhJvkNHrt79G7CzuC3R85I-2F4eIwsiU8S0En5Biw0rM4Q2RwnAwoYtu8izLDUyZBKHTlbIDcU3DOixSXiqxhInrKqD3-2FIIdkmq95ofZO6zpa2OGfb408pUsJbSQU6QafuZ-2FgHKDBznTAc8xl5vAoqmpxLLxYnLM3T4mnhjb1QH4RRAQQ5lsNA0CUsIrP7mmp7RnIU7k3PZc-3D
More information about the kimageshop
mailing list