Fix for Calligraphy qFatal, Speedup flattening

Boudewijn Rempt boud at valdyas.org
Tue Apr 14 20:45:46 UTC 2015


Awesome! I'll test it tomorrow morning, then push it :-)

Boudewijn

On Tue, 14 Apr 2015, Richard Theil wrote:

> Thanks to "Krita for Cats" I got the build running with only minor suffering and had a look. Two patches attached,
>
> #1 fixes the aborting assert I got with calligraphy. Apparently some points fed in are too close, and addCap tries to do some line algebra on a point. Crashes will be avoided if the new cutoff value is low (e.g. near FLT_EPSILON), but that causes ugly spikes to appear. I experimented a bit and settled on the 1.0 which I put in the patch (without any understanding what data is fed into addCap). Someone will have to review that, so I left a TODO. I can hardly believe that no one with a tablet came across that in either Karbon or Krita before.
>
> #2 is the speedup I suggested. Saves a few cycles over the division that was there before, but the routine seems like it's called rather frequently.
>
> Have fun,
> Rich
>
>


More information about the kimageshop mailing list