Patch to implement resource categorization via tags

Timothée Giet animtim at gmail.com
Thu May 16 15:47:30 UTC 2013


The patch is working good, cool!

Though as the filtering is case sensitive now, I'll have to rename all
presets with all-lower-case to get rid of inconsistencies.
In the same time I'll also improve naming scheme to make filtering easier.


2013/5/14 <s_suelzer at lavabit.com>

> On Tue, May 14, 2013 at 06:33:52PM +0200, Sven Langkamp wrote:
> >    Overall pretty nice work.
> >    There are a few minor things I spotted:
> >    - that empty slot in PresetDockerDock can be removed completely
> including
> >    the connections
> >    - there were some coding styles issues with missing spaces between
> >    methods
> >    - KoPresetFiltering has a misleading name, at that level we don't have
> >    presets just resources
> >    - some strings are missing the i18n() around it
> >    - this does a bit to much in one line, I think: dirty?
> ++m_changeCounter :
> >    m_oldChangeCounter = m_changeCounter;
> >
> >    As this is a Calligra wide change, it should go through reviewboard.
>
> Thank you for the reply. I will post an amended patch there, then.
>
> _______________________________________________
> Krita mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20130516/d80cfe8f/attachment.html>


More information about the kimageshop mailing list