[calligra] krita/ui/tool: end gesture when shift key is released

[Sven Langkamp]

On Thu, Dec 27, 2012 at 7:15 PM, Dmitry Kazakov <dimula73 at gmail.com> wrote:
> Hi!
>
> Well, when I was working on it I defined the interaction for the system as I
> explained in the first mail (modifier release doesn't end the interaction,
> it was even before the KisInputManager was written). It is a different
> question whether it is good or bad kind of interaction, but the fact is that
> all the gestures we have work this way right now. This patch introduces
> inconsistency among these gestures which is actually a bug (and a
> regression). The gestures affected are: brush size, canvas zoom, pan and
> rotation.
>
> I'm ok with any decision about the type of canvas interaction (either
> modifier release stops the interaction or not), but if you decide to change
> it from the current behavior, please change it for all the actions we have,
> otherwise this looks like a bug for the user. The places where it should be
> changed are: KisTool, KisInputManager.
>
> As for backporting this patch to calligra/2.6 I believe this inconsistency
> should either be fixed or the patch should be reverted from 2.6. Or just
> 'if'ed with an optional KisConfig option.

I have reverted the patch. After some discussion on irc we figured out
that the 2.6 behavior was ok and the change not needed.