[calligra/krita-iterators2-rempt] krita/image/tiles3: Handle the situation where the ng iterators get an empty stretch

Boudewijn Rempt boud at valdyas.org
Thu Apr 26 06:57:24 UTC 2012


On Wednesday 25 April 2012 Apr, Dmitry Kazakov wrote:
> > > This approach is free from both the issues: it has no additional function
> > > call for isDone() (what Cyrille wanted to achieve), and it doesn't
> > > introduce any preconditions for the iterators, which mean they can handle
> > > empty and invalid rects as well.
> >
> > On the other hand, it add extra complexity to the "nextPixel" function,
> > hence
> > cycles, to cover a corner case. Since you would have to either have a
> > check to
> > "nextPixel" to handle the first call or to positionate the iterator at
> > beginning-1, and take the risk that the iterator request an useless tile.
> >
> 
> Is there a benchmark for iterators in master?
> 
> 

Yes. I had to fix the benchmarks in my branch though, it's clear that they haven't been run for some time. We did all that work in the hack week at my place in Deventer in 2010.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl


More information about the kimageshop mailing list