Replacing KisChannelFlagsWidget with ChannelModel

[JL VT]

On Sat, Jul 2, 2011 at 10:34 AM, Sven Langkamp <sven.langkamp at gmail.com>wrote:

> On Sat, Jul 2, 2011 at 3:27 PM, JL VT <pentalis at gmail.com> wrote:
>
>> Trying to fix Bug 232141 I found other problems with the layer properties,
>> for example when setting the blue channel off it's as if deactivating the
>> red channel, and changing red is like changing blue.
>>
>> I noticed that this bug is not present in the new Channel Docker that
>> Slangkamp made, based on his ChannelModel, and that KisChannelFlagsWidget is
>> only used in KisDlgLayerProperties, which is the dialog for layer properties
>> (right click --> Properties...), then one I was trying to fix.
>>
>> Since the Model/View architecture is a more general solution, and I know
>> the reversed bug affecting channels is not affecting ChannelModel, I propose
>> renaming ChannelModel to KisChannelModel and moving it to krita/ui/ , and
>> deleting KisChannelFlagsWidget since it is completely replaced by
>> ChannelModel, which I plan to use in KisDlgLayerProperties (displayed in the
>> form of a QTableView).
>>
>> Thoughts?. Sounds good?, Sounds bad?.
>>
>
> Should be easy to fix the bug. When saving the flag it needs to use the
> channel position in the channels() list and not the index of the channel.
> That's because the channels in the channels list are ordered as BGRA but in
> the pixels they are RGBA.
>
> Thank you for the tip on fixing the bug!. I'll do that on the meanwhile.

(but I hope the thread doesn't die here, if anyone things this is a _bad
idea_ please speak up so I can see what's the problem).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20110702/ee264d62/attachment.htm