koffice/plugins/colorengines/lcms/colorspaces/rgb_u8

Boudewijn Rempt boud at valdyas.org
Tue Jan 5 08:58:12 CET 2010


On Monday 04 January 2010, Edward Apap wrote:
> SVN commit 1070109 by eapap:
> 
> Remove alpha channel manipulation after copying


I actually think that this is a legacy code path that is no longer used -- the 
real composite op copy is in libs/pigment/KoCompositeOpCopyAbstract.h. The 
only composite ops from that file that are still used are 

COMPOSITE_DARKEN
COMPOSITE_LIGHTEN
COMPOSITE_HUE
COMPOSITE_SATURATION
COMPOSITE_VALUE
COMPOSITE_COLOR
COMPOSITE_IN
COMPOSITE_OUT
COMPOSITE_DIFF
COMPOSITE_BUMPMAP
COMPOSITE_CLEAR
COMPOSITE_DISSOLVE

The rest really should be removed, and the legacy composite ops should be 
moved out of this file and made generic, where possible.


-- 
Boudewijn Rempt | http://www.valdyas.org


More information about the kimageshop mailing list