New feature for review

LukasT.dev@gmail.com lukast.dev at gmail.com
Tue Oct 27 23:06:33 CET 2009


Hello,

I added new feature to freehand and paintops. Scroll mouse button change the 
size of the paintop.

Here is the patch for review:
http://lukast.mediablog.sk/patches/0001-Feature-Scroll-wheel-changes-the-size-
of-the-spray.patch

I'm sorry for Sven, it is git format :/

What I'm doing:
I reimplement the event from KoTool in KisTool and then in Freehand tool.
In freehand tool I pass the event to the setting object of the paintop if no 
key modifiers are present (if CTRL is down, Zoom tool is in action)
Paintop setting object changes the GUI object.

The freehand code also handle the update of the brush outline.
There has to be some check code added but I was lazy, coz you can discard this 
patch and I don't want to waste my time :)

You can't recognize the size change without the brush outline as user. You 
would have to check the GUI, now the paintop settings GUI is not detachable :( 
so it is quite cumbersome.

I would like t support mypaint way of changing the brush size. That means F 
and G if I remember correctly. In the nicest case it should be configurable, 
but I need guidance on this (Oslo?).

Also for future:
Paintop settings GUI can be used for the action. E.g. you can select in GUI 
what will be changed by your scroll event and how much.
E.g. you can map the wheel event to scale of the spray or to changing the 
diameter. Or particle count.

Maybe some other modifier can be used for two modes (e.g. Shift is free now, 
Alt is for panning ).

Review please!

Lukas

http://lukast.mediablog.sk/patches/0001-Feature-Scroll-wheel-changes-the-size-
of-the-spray.patch


More information about the kimageshop mailing list