[dolphin] [Bug 458281] Pressing spacebar to trigger focused button in Selection Mode's contextual toolbar closes Selection Mode

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=458281

Felix Ernst <felixernst at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |23.04
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/commit/aac61acf4
                   |                            |1fb3ccd6f9a807984336d9be079
                   |                            |17a4
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Felix Ernst <felixernst at kde.org> ---
Git commit aac61acf41fb3ccd6f9a807984336d9be07917a4 by Felix Ernst, on behalf
of Felix Ernst.
Committed on 12/01/2023 at 11:26.
Pushed by felixernst into branch 'release/22.12'.

Make space shortcut for selection mode view-local instead of global

Before this commit, the "Space" keyboard shortcut was bound to
triggering selection mode by default. After this commit, pressing
"Space" will only trigger selection mode when the file view area
has keyboard focus.

Pros:
+ Other buttons in the UI can be triggered with Space once again
  just like it is expected from an accessibility point of view.
+ "Type-ahead" searching works once more when typing the space
  char for file names containing such a space char.

Cons:
- "Space" can no longer be used to add the currently underlined
  item to the selection. Instead "Ctrl+Space" needs to be used.
  (However, this is the current status anyway unless a user has
  manually unbound "Space" as a shortcut from Selection Mode.)
- The Selection Mode action will no longer show "Space" as its
  shortcut in menus.

Overall, I see solutions to all of these problems, but they seem
over-engineered for the issues they are trying to solve, so I
believe this somewhat small commit is the best solution for now.
Related: bug 458282, bug 463048
FIXED-IN: 23.04


(cherry picked from commit 44c82a16b3e2fc2d40601fd70f8253dce40dda86)

M  +0    -1    src/dolphinmainwindow.cpp
M  +4    -7    src/kitemviews/kitemlistcontroller.cpp
M  +5    -0    src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp
M  +10   -1    src/kitemviews/private/kitemlistkeyboardsearchmanager.h

https://invent.kde.org/system/dolphin/commit/aac61acf41fb3ccd6f9a807984336d9be07917a4

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.