[dolphin] [Bug 473999] Folders in details view expanding at wrong position - ordering by size is broken on load

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=473999

Méven Car <meven.car at kdemail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/-/commit/8f043b2
                   |                            |958477d3fe2ef094b7e42f792f4
                   |                            |cf0b02
         Resolution|---                         |FIXED

--- Comment #15 from Méven Car <meven.car at kdemail.net> ---
Git commit 8f043b2958477d3fe2ef094b7e42f792f4cf0b02 by Méven Car, on behalf of
Akseli Lahtinen.
Committed on 15/12/2023 at 14:07.
Pushed by meven into branch 'master'.

Resort directory size count after refreshing

After refreshing the view when
size count is selected as the sortRole,
count is 0 at first. When the actual count is loaded,
the sorting is done according to the count being 0. 
This can break the sort order and cause view and model
to be out of sync. 

Making sure we always resort all items
when the directory size/item count is changed fixes this

M  +7    -0    src/kitemviews/kfileitemmodel.cpp
M  +2    -0    src/kitemviews/kfileitemmodel.h
M  +3    -0    src/kitemviews/kfileitemmodelrolesupdater.cpp
M  +103  -0    src/tests/kfileitemmodeltest.cpp

https://invent.kde.org/system/dolphin/-/commit/8f043b2958477d3fe2ef094b7e42f792f4cf0b02

-- 
You are receiving this mail because:
You are on the CC list for the bug.