[frameworks-kio] [Bug 453890] Umount icon unnecessarily shown for internal drives

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=453890

Kai Uwe Broulik <kde at privat.broulik.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kio/commit/69b077708
                   |                            |99098afd879f7dc1ed5f519f1df
                   |                            |ba7d

--- Comment #13 from Kai Uwe Broulik <kde at privat.broulik.de> ---
Git commit 69b07770899098afd879f7dc1ed5f519f1dfba7d by Kai Uwe Broulik.
Committed on 24/05/2022 at 13:44.
Pushed by ngraham into branch 'master'.

[KFilePlacesView] Show inline eject button only for removable drives

Otherwise it clutters a list of internal drives that are never meant
to be unmounted, and potentially not even allowed to be, with eject icons.

Also, we currently only show fixed network shares (e.g. through fstab),
which are usually not meant to be unmounted by the user.

Storage without a drive (e.g. a mounted ISO image) keeps its eject inline
button, too.

Triggering an unmount from the contextmenu remains possible (except for
Root and Home, as before).

M  +16   -0    src/filewidgets/kfileplacesitem.cpp
M  +2    -0    src/filewidgets/kfileplacesitem_p.h
M  +11   -0    src/filewidgets/kfileplacesmodel.cpp
M  +9    -0    src/filewidgets/kfileplacesmodel.h
M  +1    -1    src/filewidgets/kfileplacesview.cpp

https://invent.kde.org/frameworks/kio/commit/69b07770899098afd879f7dc1ed5f519f1dfba7d

-- 
You are receiving this mail because:
You are on the CC list for the bug.