[dolphin] [Bug 452289] service-menu-installer ignores symlinks on uninstall

[Christian Hartmann]

https://bugs.kde.org/show_bug.cgi?id=452289

Christian Hartmann <hartmann.christian at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/commit/65413bbad
                   |                            |29ea31ea0fab83bbe0f55a3befc
                   |                            |5a11
         Resolution|---                         |FIXED

--- Comment #2 from Christian Hartmann <hartmann.christian at gmail.com> ---
Git commit 65413bbad29ea31ea0fab83bbe0f55a3befc5a11 by Christian Hartmann.
Committed on 21/05/2022 at 06:21.
Pushed by felixernst into branch 'master'.

fix: service-menu-installer ignoring symlinks on un-install

service-menu-installer ignores <package-name>.tar.gz-dir/uninstall.sh
if this is actualy just a symbolic link to install.sh in the same directory
(hardlinks and copies work)

canonicalPath() is used to get the name of the file on disk and returns
install.sh
in the case of a symbolic link. install.sh without any arguments is called
instead
of uninstall.sh consequently and no de-installation takes place.

replace canonicalPath() with absolutePath() as used in the rest of source file

resolves:

M  +1    -1   
src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp

https://invent.kde.org/system/dolphin/commit/65413bbad29ea31ea0fab83bbe0f55a3befc5a11

-- 
You are receiving this mail because:
You are on the CC list for the bug.