[dolphin] [Bug 439877] Dolphin crashes when right-clicking on file or folder to summon the contextual menu

[Paul Brown]

https://bugs.kde.org/show_bug.cgi?id=439877

--- Comment #4 from Paul Brown <paul.brown at kde.org> ---
(In reply to Harald Sitter from comment #2)
> Git commit 07d54af0b6e3f074a9e679db506fc538f52cc410 by Harald Sitter.
> Committed on 15/07/2021 at 14:01.
> Pushed by sitter into branch 'release/21.08'.
> 
> don't auto deduce QStringBuilder
> 
> see 'auto QString(Builder) considered VERY HARMFUL' thread on kde-devel
> https://markmail.org/message/mbrp5ypyhcfk7zjn
> 
> What happens is that the type of str ends up being QStringBuilder
> instead of QString. The QStringBuilder is destroyed after the semicolon,
> and all access to "str" produces undefined behavior.
> 
> Never use auto for QString concatenation!
> 
> M  +1    -1   
> activities/fileitemplugin/FileItemLinkingPluginActionLoader.cpp
> 
> https://invent.kde.org/network/kio-extras/commit/
> 07d54af0b6e3f074a9e679db506fc538f52cc410

Thanks, Harald!

-- 
You are receiving this mail because:
You are on the CC list for the bug.