Review Request 125383: [dolphin-plugins]Fix for adding issues for git plugin

[Emmanuel Pescosta]

> On Sept. 26, 2015, 4:08 p.m., Emmanuel Pescosta wrote:
> > git/fileviewgitplugin.cpp, line 275
> > <https://git.reviewboard.kde.org/r/125383/diff/2/?file=408481#file408481line275>
> >
> >     QFileInfo().absolutePath() is not needed anymore, QDir().canonicalPath() does the same (+ symlink resolution)
> 
> Tomasz Bojczuk wrote:
>     QFileInfo().absolutePath() returns directory path of given item when canonicalPath() converts whatever it gets (file or directory)
>     or QProcess::setWorkingDirecory(file_without_symlinks) will bear file as an argument as well?

Ah then use QFileInfo().canonicalPath() ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125383/#review85972
-----------------------------------------------------------


On Sept. 26, 2015, 4:05 p.m., Tomasz Bojczuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125383/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2015, 4:05 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=352625
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=352625
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> This pach reverts my previous fix, which solved only side effect of the main problem.
> Main problem is clearing QProcess working directory of 'git' command when context menu of a file is invoked.
> Now working directory is set there instead of clearing. Then 'git' is capable to work with relative file paths.
> 
> 
> Diffs
> -----
> 
>   git/fileviewgitplugin.cpp 4b5b1c5 
> 
> Diff: https://git.reviewboard.kde.org/r/125383/diff/
> 
> 
> Testing
> -------
> 
> Of course....
> I uses/using it "even" with real (production) projects.
> 
> 
> Thanks,
> 
> Tomasz Bojczuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150926/7dc5595b/attachment.htm>