Review Request: Fix bookmarks "Recently Accessed" and "Search for" not available with default install

Luc Menut lmenut at free.fr
Sun Nov 25 19:24:20 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107464/
-----------------------------------------------------------

Review request for Dolphin, Vishesh Handa, Peter Penz, and Frank Reininghaus.


Description
-------

The bookmarks for "Recently Accessed" and "Search for" is not available in dolphin after a default install, since git rev. f5b6fbf7
  https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/f5b6fbf7747cefceef4bcd31d90d053da5c560c4

With a default install, indexing is enabled by default and [Service-nepomukfileindexer]autostart is not written in nepomukserverrc.
  https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/nepomuk/kcm/nepomukserverkcm.cpp#L216

Because in dolphin, placesitemmodel.cpp line 93 
  m_fileIndexingEnabled = config.group("Service-nepomukfileindexer").readEntry("autostart", false)
default to false if [Service-nepomukfileindexer]autostart is missing, m_fileIndexingEnabled is false by default even if indexing is available.

m_fileIndexingEnabled should follow the default value (true) of nepomukserverkcm m_checkEnableFileIndexer.

The suggested patch fixes this issue.

regards,
Luc Menut - Mageia

PS: I don't have write access to kde git, so could you commit the change for me if the patch looks fine. Thanks.


Diffs
-----

  dolphin/src/panels/places/placesitemmodel.cpp a37c17f 

Diff: http://git.reviewboard.kde.org/r/107464/diff/


Testing
-------

tested with KDE 4.9.80 (Mageia Cauldron)


Thanks,

Luc Menut

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121125/9f46ffa6/attachment.htm>


More information about the kfm-devel mailing list