<table><tr><td style="">jfita added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29230">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29230#inline-169915">View Inline</a><span style="color: #4b4d51; font-weight: bold;">staniek</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kexirecordnavigator.cpp:359</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">It would be nice to have this algorithm explained briefly here as well as the 120 constant (it can be named too).</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Quite frankly, i do not know what this 120 means. As i tried to imply in the summary, i copied this code from QAbstractSlider, the base for Qt scrollbars, so that it would work and feel like a QScrollArea.</p>
<p style="padding: 0; margin: 8px;">The <a href="https://code.qt.io/cgit/qt/qt.git/commit/?id=0fd6390800969d174dba819c54c4183a99e8f83c" class="remarkup-link" target="_blank" rel="noreferrer">most relevant change in Qt’s repository related to this value</a>, from the days of Qt 4, does not provide any insight to me as to where this value comes from.</p>
<p style="padding: 0; margin: 8px;">Would a comment saying “code copied from QAbstractSlider” or the like be sufficient?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R71 Kexi</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29230">https://phabricator.kde.org/D29230</a></div></div><br /><div><strong>To: </strong>jfita, staniek, piggz<br /><strong>Cc: </strong>Kexi-Devel-list, barman, staniek<br /></div>